mod_backup: lookup db settings from pgsql_pool. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mworrell
added a commit
that referenced
this pull request
Oct 31, 2011
mod_backup: lookup db settings from pgsql_pool.
rpip
pushed a commit
to rpip/zotonic
that referenced
this pull request
Aug 12, 2013
mod_backup: lookup db settings from pgsql_pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In z_site_sup:add_db_pool/3, there is a fallback for the db settings, using the options from z_config.
This patch makes sure that mod_backup uses the same db settings as all other db queries, without relying on fallbacks etc.
Also, a minor grammatic fix has slipped through... :)