Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl password to support private key with pem pass phrase #332

Closed
wants to merge 3 commits into from

Conversation

barcoyou
Copy link

Dear Founders,

I just add patch to solve the HTTPs crash problem posted on Google group. The cause is that the certificate and private key has pem passphrase whereas zotonic didn't convey this info to ssl.

Thanks!
Barco You

@kaos
Copy link
Member

kaos commented May 18, 2012

Thanks for the contribution. :)
The first two commits have my thumbs up.

I think that the priv/ssl/README ought to be in the doc directory as a README-SSL or similar, if any where at all.

@arjan arjan closed this in 3594cc1 May 18, 2012
@barcoyou
Copy link
Author

Sorry for making trouble and I'm glad to get chance to contribute.

@arjan
Copy link
Member

arjan commented May 18, 2012

Thanks anyway! :-)

@kaos
Copy link
Member

kaos commented May 18, 2012

@arjan hint: git commit --author=...
(to give proper credit :)
you'll be listed as committer any way.

@barcoyou
Copy link
Author

Thanks! I'm very proud to be able to work together with you!

@arjan
Copy link
Member

arjan commented May 19, 2012

@kaos actually barco's commit was 3a78a99, I did another commit just to fix indentation.

@kaos
Copy link
Member

kaos commented May 20, 2012

Oh, right, I should've seen that... :-p

rpip pushed a commit to rpip/zotonic that referenced this pull request Aug 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants