FIX z_string:s_utf8/2 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current checker does not validate that codepoints are within allowed range. For instance, this encodes U-00000, but passes the current validator: <<2#110:3, 0:5, 2#10:2, 0:6>>. (<<16#C080>>). New checker takes into account both utf8 syntax and allowed values that certain length codepoints can encode.
|
Is your name already in the Contributors file? |
|
Thanks! |
|
Thanks for merging. As for name and email, please include the one in the commit message. |
rpip
pushed a commit
to rpip/zotonic
that referenced
this pull request
Aug 12, 2013
FIX z_string:s_utf8/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current checker does not validate that codepoints are within allowed
range. For instance, this encodes U-00000, but passes the current
validator:
<<2#110:3, 0:5, 2#10:2, 0:6>>. (<<16#C080>>).New checker takes into account both utf8 syntax and allowed values that
certain length codepoints can encode.
Background: I was looking for an Erlang utf-8 validator and generator for a bigger project and came across this one. Validator was wrong, so I fixed it. Since there is also a PropEr generator and PropEr test suite, it has a separate repository:
https://github.com/Motiejus/z_string
Note: I did not include PropEr test suite, because PropEr is another dependency. For a more complete test suite see the link above.