Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read public key from keyring #3212

Merged
merged 21 commits into from
Nov 22, 2023
Merged

fix: read public key from keyring #3212

merged 21 commits into from
Nov 22, 2023

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Nov 22, 2023

Description

Configuration for public key read was separated from common configuration. It was missing a logic to update the keyring path and as such was failing for the keyring setup. This change reuses configuration from the common bean.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: achmelo <a.chmelo@gmail.com>
# Conflicts:
#	api-catalog-ui/frontend/config-overrides.js
Signed-off-by: achmelo <a.chmelo@gmail.com>
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@achmelo achmelo merged commit a0a6937 into v2.x.x Nov 22, 2023
32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/ac/cgw_keyring_fix branch November 22, 2023 16:27
pj892031 pushed a commit that referenced this pull request Nov 24, 2023
* chore: move babel to dev, modify webpack config, spring security

Signed-off-by: achmelo <a.chmelo@gmail.com>

* read keys from common httpsconfig

Signed-off-by: achmelo <a.chmelo@gmail.com>

---------

Signed-off-by: achmelo <a.chmelo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants