Configurable certificate validation #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
JirkaAichler
approved these changes
Nov 19, 2018
| @@ -113,13 +160,13 @@ private void startTomcatAndDoHttpsRequest(HttpsConfig httpsConfig) throws IOExce | |||
|
|
|||
| private HttpsConfig.HttpsConfigBuilder correctHttpsKeyStoreSettings() throws IOException { | |||
There was a problem hiding this comment.
IOException is never thrown
| @@ -103,9 +109,9 @@ public static void main(String[] args) throws LifecycleException, ClientProtocol | |||
|
|
|||
| HttpsConfig httpsConfig = HttpsConfig.builder() | |||
| .keyStore(new File("keystore/localhost/localhost.keystore.p12").getCanonicalPath()) | |||
| .keyStorePassword("password").keyPassword("password") | |||
| .keyStorePassword(STORE_PASSWORD).keyPassword(STORE_PASSWORD) | |||
There was a problem hiding this comment.
ClientProtocolException is never thrown because of more general exception
| @@ -41,7 +41,8 @@ | |||
|
|
|||
| @Slf4j | |||
| public class TomcatServerFactory { | |||
| private final static String SERVLET_NAME = "hello"; | |||
| private static final String SERVLET_NAME = "hello"; | |||
| private static final String STORE_PASSWORD = "password"; // NOSONAR | |||
|
|
|||
| public Tomcat startTomcat(HttpsConfig httpsConfig) throws IOException { | |||
| Tomcat tomcat = new Tomcat(); | |||
There was a problem hiding this comment.
ServletException is never thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79.
This PR brings a possibility to use and register services that do not have trusted certificate to the APIML.
The functionality is covered by some "unit" tests in TomcatHttpsTests but it was also tested manually with a real service:
localhost2.keystore.p12) has been used inconfig/local/discoverable-client.yml--apiml.security.verifySslCertificatesOfServices=falsewas set inpackage.jsonfo GW, DS, and ACThis is documented in the documentation for developers (inside api-layer repository) on purpose because certificate validation is recommended for other users.