Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of Discovery Service (our code) #407

Merged
merged 28 commits into from
Oct 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
20bbd11
Added logger to Discovery
jandadav Oct 3, 2019
09481c8
Additional files
jandadav Oct 3, 2019
eaf2c2c
Added logger messages to discovery related apiml-common classes
Oct 4, 2019
a000f5f
- log filter for apiml messages of info and lower
jandadav Oct 7, 2019
e46d405
Added more logger messages to discovery related apiml-common classes
Oct 9, 2019
d3c47c7
separate messages yaml files per module
Oct 10, 2019
81307e6
tweaked the LogLevelInfoFilter
jandadav Oct 10, 2019
ee4d455
style check fixes
vsev0lod Oct 11, 2019
637ac00
Changed message structure
Oct 11, 2019
bfbfbbd
Changed message number
Oct 11, 2019
7922435
removed the test components
jandadav Oct 11, 2019
81c6080
aligned message code and keys
jandadav Oct 11, 2019
bc6c160
Service startup message
jandadav Oct 11, 2019
c243070
Code review edits
jandadav Oct 11, 2019
ab94006
add few more log messages
Oct 14, 2019
a144ad4
aligned keys case
jandadav Oct 14, 2019
eb61fe7
cleaned logLevelInfoFilter
jandadav Oct 14, 2019
118f303
key to module alignment
jandadav Oct 14, 2019
fc81afd
removed duplicate message for HTTP
jandadav Oct 14, 2019
c64db33
moved service started message
jandadav Oct 14, 2019
fe654c8
removed obsolete import
jandadav Oct 14, 2019
96aa44d
message categories and renumbering
jandadav Oct 14, 2019
43ba68f
numbers adjusting
vsev0lod Oct 14, 2019
29076d7
redundant slf4j logger removed
vsev0lod Oct 14, 2019
b586041
aligned the yaml message ranges
jandadav Oct 15, 2019
e53ac42
missing dir i/o error
jandadav Oct 15, 2019
b723224
syntax error
Oct 15, 2019
5097f9e
Fixes from Review
jandadav Oct 16, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

import com.ca.mfaas.enable.EnableApiDiscovery;
import com.ca.mfaas.product.monitoring.LatencyUtilsConfigInitializer;
import com.ca.mfaas.product.service.BuildInfo;
import com.ca.mfaas.product.version.BuildInfo;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.netflix.eureka.EnableEurekaClient;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import com.ca.mfaas.message.core.MessageService;
import com.ca.mfaas.product.gateway.GatewayClient;
import com.ca.mfaas.product.routing.transform.TransformService;
import lombok.extern.slf4j.Slf4j;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Primary;
Expand All @@ -21,7 +20,6 @@
* General configuration of the API Catalog.
*/
@Configuration
@Slf4j
public class BeanConfig {

@Bean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
*/
package com.ca.mfaas.apicatalog.config;

import lombok.extern.slf4j.Slf4j;
import org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory;
import org.springframework.boot.web.servlet.server.ServletWebServerFactory;
import org.springframework.context.annotation.Bean;
Expand All @@ -19,7 +18,6 @@
* Configuration of Tomcat for the API Gateway.
*/
@Configuration
@Slf4j
public class TomcatConfiguration {

@Bean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

import com.ca.mfaas.apicatalog.services.status.APIServiceStatusService;
import io.swagger.annotations.*;
import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.MediaType;
import org.springframework.http.ResponseEntity;
Expand All @@ -24,7 +23,6 @@
/**
* Main API for handling requests from the API Catalog UI, routed through the gateway
*/
@Slf4j
@RestController
@RequestMapping("/apidoc")
@Api(tags = {"API Documentation"},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import com.ca.mfaas.message.core.Message;
import com.ca.mfaas.message.core.MessageService;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.ControllerAdvice;
Expand All @@ -24,7 +23,6 @@
/**
* This class creates responses for exceptional behavior of the ApiCatalogController
*/
@Slf4j
@ControllerAdvice(assignableTypes = {ApiCatalogController.class})
@RequiredArgsConstructor
public class ApiCatalogControllerExceptionHandler {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import com.ca.mfaas.message.core.Message;
import com.ca.mfaas.message.core.MessageService;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.ControllerAdvice;
Expand All @@ -25,7 +24,6 @@
/**
* This class creates responses for exceptional behavior of the CatalogApiDocController
*/
@Slf4j
@ControllerAdvice(assignableTypes = {CatalogApiDocController.class})
@RequiredArgsConstructor
public class CatalogApiDocControllerExceptionHandler {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
*/
package com.ca.mfaas.apicatalog.controllers.handlers;

import lombok.extern.slf4j.Slf4j;
import org.springframework.boot.web.servlet.error.ErrorController;
import org.springframework.core.Ordered;
import org.springframework.core.annotation.Order;
Expand All @@ -24,7 +23,6 @@
/**
* Handles errors in REST API processing.
*/
@Slf4j
@Controller
@Order(Ordered.HIGHEST_PRECEDENCE)
public class NotFoundErrorController implements ErrorController {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import com.netflix.appinfo.InstanceInfo;
import lombok.NonNull;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.http.*;
import org.springframework.stereotype.Service;
import org.springframework.web.client.RestTemplate;
Expand All @@ -35,7 +34,6 @@
/**
* Retrieves the API documentation for a registered service
*/
@Slf4j
@Service
@RequiredArgsConstructor
public class APIDocRetrievalService {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,13 @@
package com.ca.mfaas.apicatalog.services.status.listeners;

import com.ca.mfaas.product.service.ServiceStartupEventHandler;
import lombok.extern.slf4j.Slf4j;
import org.springframework.boot.context.event.ApplicationReadyEvent;
import org.springframework.context.event.EventListener;
import org.springframework.stereotype.Component;

/**
* This class fires on ApplicationReadyEvent event during Spring context initialization
*/
@Slf4j
@Component
public class AppReadyListener {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import com.ca.mfaas.product.gateway.GatewayLookupCompleteEvent;
import com.ca.mfaas.product.registry.CannotRegisterServiceException;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.context.event.EventListener;
import org.springframework.core.Ordered;
import org.springframework.core.annotation.Order;
Expand All @@ -23,7 +22,6 @@
* This class fires on GatewayLookupCompleteEvent event
* Initializes Catalog instances from Eureka
*/
@Slf4j
@Component
@RequiredArgsConstructor
@Order(Ordered.HIGHEST_PRECEDENCE)
Expand Down
Loading