Add Jobs search label to profile node

[kristinochka]

Signed-off-by: KRISTINA MAYO ktopchi@us.ibm.com

Proposed changes

#2062

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

[codecov]

Codecov Report

Base: 89.25% // Head: 89.31% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (9a76fd3) compared to base (b9089b0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
+ Coverage   89.25%   89.31%   +0.06%     
==========================================
  Files          85       85              
  Lines        8081     8080       -1     
  Branches     1704     1703       -1     
==========================================
+ Hits         7213     7217       +4     
+ Misses        867      862       -5     
  Partials        1        1              

Impacted Files	Coverage Δ
packages/zowe-explorer/src/job/ZosJobsProvider.ts	91.42% <100.00%> (+0.01%)	⬆️
packages/zowe-explorer/src/job/ZoweJobNode.ts	86.11% <100.00%> (+2.59%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[zFernand0]

The enhancement seems very straightforward and useful.
I left one comment about the changelog.

Q: should we consider making this a bit more dynamic for V3?
For instance, other people may find more value in seeing specific information (that I'm sure we have available) in certain labels.
Just something to think about 😋

[kristinochka]

Q: should we consider making this a bit more dynamic for V3? For instance, other people may find more value in seeing specific information (that I'm sure we have available) in certain labels.

An example would be helpful here. We can definitely discuss this use case.

[kristinochka]

@zFernand0 Ready to review now.

[zFernand0]

@zFernand0 Ready to review now.

Happy to review it again.
Please keep in mind that this is an enhancement and thus should stay with main as the target branch for a future 2.7.0 release of Zowe Explorer.

[zFernand0]

@kristinochka
Seems to work as expected.
There seems to be a very annoying issue to work around.

• See Unable to change the owner in a job search #2112

[kristinochka]

@zFernand0 Thanks, Billie Jean is out this week, Could we add somebody else to review or merge?

[kristinochka]

#2112 Seems to be a new regression.

[traeok]

LGTM! Thanks @kristinochka

I also noticed #2112 and was able to make a fix on a local branch. Didn't realize that you had self-assigned the issue until after I completed it. If desired I can make a PR for this 😅

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[zFernand0]

There might be a slight issue with the updates made to the labels.
Based on @adam-wolfe's comments during yesterday's call, we looked into things a bit closer regarding favorites and found that the updated labels break the searching capabilities from a favorited job-search.