Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data set members may fail to open in binary mode #2696

Closed
t1m0thyj opened this issue Jan 30, 2024 · 4 comments · Fixed by #2882
Closed

Data set members may fail to open in binary mode #2696

t1m0thyj opened this issue Jan 30, 2024 · 4 comments · Fixed by #2882
Assignees
@t1m0thyj
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Milestone
v2.16.0

Comments

@t1m0thyj
Copy link
Member

Data set members cannot always be opened in binary mode depending on the contents.

The following member can be opened in binary mode (as long as there is no trailing line) because it is exactly 80 bytes long:

Hello World                                                                    $

Attempting to open the following member in binary mode results in an error:

Hello World $

Here are the attributes of the PDS:
@t1m0thyj t1m0thyj added the bug Something isn't working label Jan 30, 2024
@t1m0thyj t1m0thyj changed the title Data set members fail to open in binary mode Data set members may fail to open in binary mode Jan 30, 2024
@github-actions GitHub Actions
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@JTonda JTonda added priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. labels Feb 1, 2024
@zowe-robot zowe-robot moved this from New Issues to Medium Priority in Zowe Explorer for VS Code Feb 1, 2024
@adam-wolfe
Copy link
Contributor

Also running into this issue with allocation settings:
image

@t1m0thyj
Copy link
Member Author

t1m0thyj commented Apr 9, 2024

Discussed with @awharn and realized we could probably reuse some of the logic for opening USS nodes, to catch an error when opening a data set and fall back to binary mode: https://github.com/zowe/zowe-explorer-vscode/blob/main/packages/zowe-explorer/src/uss/ZoweUSSNode.ts#L624

@t1m0thyj t1m0thyj self-assigned this Apr 23, 2024
@t1m0thyj t1m0thyj mentioned this issue Apr 25, 2024
Merged
16 tasks
@t1m0thyj t1m0thyj linked a pull request Apr 25, 2024 that will close this issue
fix(ds): Support opening data sets in binary mode #2882
Merged
16 tasks
@JillieBeanSim
Copy link
Contributor

Closing with merge of PR linked

@github-project-automation github-project-automation bot moved this from Medium Priority to Closed in Zowe Explorer for VS Code May 8, 2024
@JillieBeanSim JillieBeanSim added this to the v2.16.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t1m0thyj t1m0thyj

Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging a pull request may close this issue.

fix(ds): Support opening data sets in binary mode zowe/zowe-explorer-vscode
4 participants
@t1m0thyj @JTonda @JillieBeanSim @adam-wolfe