-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zowe sdks and return etag from uploadFromBuffer #2785
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2785 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 110 110
Lines 10246 10246
Branches 2079 2178 +99
=======================================
Hits 9560 9560
Misses 685 685
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
No need to update every changelog if the only thing that happened was a dependency update/refresh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @t1m0thyj 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @t1m0thyj -- left one minor comment.
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @t1m0thyj 😋
Proposed changes
Fixes Zowe Explorer failing to build after updating the SDKs to the latest version.
After this PR is merged we should be able to update #2777 to make fewer API calls 😋
Release Notes
Milestone: v3
Changelog: Removed string as a return type of
uploadFromBuffer
, since the z/OSMF API has been fixed to return a response object that includes an etagNote: Changelog check is failing for zowe-explorer and ftp packages, but I don't think release notes are needed for just updating the sdks.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments