Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zowe sdks and return etag from uploadFromBuffer #2785

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Mar 14, 2024

Proposed changes

Fixes Zowe Explorer failing to build after updating the SDKs to the latest version.

After this PR is merged we should be able to update #2777 to make fewer API calls 😋

Release Notes

Milestone: v3

Changelog: Removed string as a return type of uploadFromBuffer, since the z/OSMF API has been fixed to return a response object that includes an etag

Note: Changelog check is failing for zowe-explorer and ftp packages, but I don't think release notes are needed for just updating the sdks.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj added this to the v3 pre-releases milestone Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (1c05a33) to head (1b52861).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2785   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         110      110           
  Lines       10246    10246           
  Branches     2079     2178   +99     
=======================================
  Hits         9560     9560           
  Misses        685      685           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zFernand0
zFernand0 previously approved these changes Mar 14, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
No need to update every changelog if the only thing that happened was a dependency update/refresh

traeok
traeok previously approved these changes Mar 14, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj 🙂

anaxceron
anaxceron previously approved these changes Mar 14, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @t1m0thyj -- left one minor comment.

packages/zowe-explorer-api/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj dismissed stale reviews from anaxceron, traeok, and zFernand0 via 1b52861 March 15, 2024 13:29
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj 😋

@t1m0thyj t1m0thyj merged commit 3cc5b42 into next Mar 15, 2024
20 of 21 checks passed
@t1m0thyj t1m0thyj deleted the fix/update-zowe-sdks branch March 15, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants