Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bs-platform 3 and fix bool warnings #55

Merged
merged 1 commit into from
May 5, 2018
Merged

Upgrade to bs-platform 3 and fix bool warnings #55

merged 1 commit into from
May 5, 2018

Commits on May 4, 2018

  1. Upgrade to bs-platform 3 and fix bool warnings

    This allows us to eliminate a ton of boilerplate conversion since
    BuckleScript bools are now represented by JS booleans under the
    hood. This patch make a couple of changes across the codebase.
    
    - Convert all instances of Js.true_ to true and Js.boolean to bool.
    - Remove use of conversion functions like Js.Boolean.to_js_boolean.
    - Where wrapper functions only existed to convert between boolean
      representations, we remove the wrapper function.
    - Remove Util.optBoolToJs() and any wrapper functions that only
      served to apply that function to some of the arguments.
    
    This eliminates all warnings when building with BS 3.0.0.
    zploskey committed May 4, 2018
    Configuration menu
    Copy the full SHA
    7aa52b5 View commit details
    Browse the repository at this point in the history