Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Page.viewport and Page.emulate #71

Merged
merged 2 commits into from
Aug 4, 2018
Merged

Fix Page.viewport and Page.emulate #71

merged 2 commits into from
Aug 4, 2018

Commits on Aug 4, 2018

  1. Fix Page.viewport and Page.emulate 

    Cleanup of code associated with the Page.viewport type.

- Make all fields in viewport optional except for width and height.
- Construct the viewport using bs.deriving abstract.
- Introduce Page.Viewport module for this type.
- Remove unnecessary unit argument to Page.viewport().
- Rename Page.emulateOption to emulateOptions.
    @zploskey
    zploskey committed Aug 4, 2018
    Configuration menu
    Copy the full SHA
    f2eaa2d View commit details
    Browse the repository at this point in the history

  2. Don't alias Viewport for one function call

    @zploskey
    zploskey committed Aug 4, 2018
    Configuration menu
    Copy the full SHA
    073fabc View commit details
    Browse the repository at this point in the history