Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include target url when setting commit status to 'error' #7

Open
zpnk opened this issue Nov 26, 2016 · 1 comment
Open

Do not include target url when setting commit status to 'error' #7

zpnk opened this issue Nov 26, 2016 · 1 comment

Comments

@zpnk
Copy link
Owner

zpnk commented Nov 26, 2016

See here and here.

The url will usually result in a 404 from now.sh anyway since the deploy failed. Including it can be confusing if the user tries to click on it to find out what the error was.

@jimthedev
Copy link
Contributor

This also plays into #14 / #8 since at the moment if you happened an existing deploy with the same then you would not see a 404 and instead would see the first deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants