fix: incorrect error message in ASTree::BuildFromCode(...)
#511
Conversation
ASTree.cpp
Outdated
| @@ -2474,7 +2474,8 @@ PycRef<ASTNode> BuildFromCode(PycRef<PycCode> code, PycModule* mod) | |||
| } | |||
| break; | |||
| default: | |||
| fprintf(stderr, "Unsupported opcode: %s\n", Pyc::OpcodeName(opcode & 0xFF)); | |||
| int bytecode = code->code()->value()[curpos] & 0xFF; | |||
There was a problem hiding this comment.
Reading directly from the code object doesn't handle the EXTENDED_ARG case properly... Perhaps just printing the position is sufficient, since it can be used to look up the context in disassembly.
* `opcode` was incorrectly clamped causing misleading output. * modified output with additional info about offending bytecode and position so end-user submissions can become more informative. * for `EXTENDED_ARG` bytecode the position will be off by a few bytes, but, at least the bytecode printed will be correct.
|
indeed, i overlooked the the update i've pushed instead relies on i also updated the disasm code with a similar change (to include the offending bytecode in the output.) |
opcodewas incorrectly clamped causing misleading output.modified output with additional info about offending bytecode and position so end-user submissions can become more informative.