Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did JNVMf handle the NVME AER correctly? #13

Closed
gwnet opened this issue Aug 5, 2019 · 6 comments
Closed

did JNVMf handle the NVME AER correctly? #13

gwnet opened this issue Aug 5, 2019 · 6 comments

Comments

@gwnet
Copy link

gwnet commented Aug 5, 2019

No description provided.

@PepperJo
Copy link
Contributor

PepperJo commented Aug 5, 2019

AER is PCIe specific and is not supported via NVMf to my knowledge. It is the target's responsibility to handle such failures.

@PepperJo PepperJo closed this as completed Aug 6, 2019
@gwnet
Copy link
Author

gwnet commented Aug 6, 2019

buddy, you get it wrong. there are two AER. one is PCIE advanced error reporting.
another is NVMe async event report. I am talking the NVMe async event AER now. SPDK and kernel handle this.

@PepperJo
Copy link
Contributor

PepperJo commented Aug 7, 2019

Thanks for the clarification. Request async event resp. get log page is not supported yet. However, it should be fairly easy to implement them.

@gwnet
Copy link
Author

gwnet commented Aug 7, 2019

may I know what is impact if we did not have it?

@PepperJo
Copy link
Contributor

PepperJo commented Aug 8, 2019

From my knowledge async events are rarely used. Generally if there is a real problem your operations will fail eventually which will be handled as expected by jNVMf. For async events read NVMe Spec 1.3 page 77 / 5.2 it explains what type of events you can get.

@PepperJo PepperJo reopened this Aug 15, 2019
@PepperJo
Copy link
Contributor

Added async event request and get log page support: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants