Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new oracledb package #24

Closed
troyswanson opened this issue Jun 14, 2022 · 5 comments · Fixed by #25
Closed

Add support for new oracledb package #24

troyswanson opened this issue Jun 14, 2022 · 5 comments · Fixed by #25

Comments

@troyswanson
Copy link
Contributor

It looks like Oracle is changing their driver package to be (mostly) pure Python, and is changing some of the interfaces.

Here's a link to some documentation that shows all of the differences:
https://python-oracledb.readthedocs.io/en/latest/user_guide/appendix_c.html

@zschumacher
Copy link
Owner

Thanks for the issue, I’ll take a look at adding that this weekend!

@troyswanson
Copy link
Contributor Author

@zschumacher I made a pretty basic PR that's just a copy/paste job from the cx_Oracle implementation. I'm happy to continue working on it based on any code review comments you have.

@zschumacher
Copy link
Owner

@troyswanson PR looks great, just need to update docs. Let me know as you come across anything that wasn't obvious from a contribution standpoint and I can get some contributing docs up.

@troyswanson
Copy link
Contributor Author

Thanks! It's been generally pretty easy so far. Had to figure out how to install extras using Poetry.

Also, switching to using the new oracledb driver as the default would be helpful for anyone getting started since it doesn't require the Instant Client to do basic database operations.

@zschumacher
Copy link
Owner

yeah the instant client is a pain for sure. I opened #28 and will consider doing that when I 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants