Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 5.2 support #20

Open
kit-ty-kate opened this issue Feb 22, 2024 · 2 comments
Open

OCaml 5.2 support #20

kit-ty-kate opened this issue Feb 22, 2024 · 2 comments

Comments

@kit-ty-kate
Copy link

OCaml 5.2 added support for float16 and makes py fails with:

#=== ERROR while compiling py.1.3 =============================================#
# context              2.2.0~beta2~dev | linux/x86_64 | ocaml-variants.5.2.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/py.1.3
# command              ~/.opam/5.2/bin/dune build -p py -j 1
# exit-code            1
# env-file             ~/.opam/log/py-20-0f7a72.env
# output-file          ~/.opam/log/py-20-0f7a72.out
### output ###
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.py.objs/byte -I /home/opam/.opam/5.2/lib/bigarray-compat -I /home/opam/.opam/5.2/lib/ctypes -I /home/opam/.opam/5.2/lib/ctypes-foreign -I /home/opam/.opam/5.2/lib/integers -I /home/opam/.opam/5.2/lib/ocaml/threads -I /home/opam/.opam/5.2/lib/ocaml/unix -I /home/opam/.opam/5.2/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -open Py__ -o src/.py.objs/byte/py__Py_base.cmo -c -impl src/py_base.ml)
# File "src/py_base.ml", lines 842-855, characters 12-73:
# 842 | ............match Bigarray.Genarray.kind bigarray with
# 843 |             | Bigarray.Float32        -> 11
# 844 |             | Bigarray.Float64        -> 12
# 845 |             | Bigarray.Int8_signed    -> 1
# 846 |             | Bigarray.Int8_unsigned  -> 2
# ...
# 852 |             | Bigarray.Nativeint      -> failwith "native int is not supported"
# 853 |             | Bigarray.Complex32      -> failwith "complex32 is not supported"
# 854 |             | Bigarray.Complex64      -> failwith "complex64 is not supported"
# 855 |             | Bigarray.Char           -> failwith "char is not supported"
# Error (warning 8 [partial-match]): this pattern-matching is not exhaustive.
# Here is an example of a case that is not matched:
# Float16
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlopt.opt -w -40 -g -I src/.py.objs/byte -I src/.py.objs/native -I /home/opam/.opam/5.2/lib/bigarray-compat -I /home/opam/.opam/5.2/lib/ctypes -I /home/opam/.opam/5.2/lib/ctypes-foreign -I /home/opam/.opam/5.2/lib/integers -I /home/opam/.opam/5.2/lib/ocaml/threads -I /home/opam/.opam/5.2/lib/ocaml/unix -I /home/opam/.opam/5.2/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -open Py__ -o src/.py.objs/native/py__Py_base.cmx -c -impl src/py_base.ml)
# File "src/py_base.ml", lines 842-855, characters 12-73:
# 842 | ............match Bigarray.Genarray.kind bigarray with
# 843 |             | Bigarray.Float32        -> 11
# 844 |             | Bigarray.Float64        -> 12
# 845 |             | Bigarray.Int8_signed    -> 1
# 846 |             | Bigarray.Int8_unsigned  -> 2
# ...
# 852 |             | Bigarray.Nativeint      -> failwith "native int is not supported"
# 853 |             | Bigarray.Complex32      -> failwith "complex32 is not supported"
# 854 |             | Bigarray.Complex64      -> failwith "complex64 is not supported"
# 855 |             | Bigarray.Char           -> failwith "char is not supported"
# Error (warning 8 [partial-match]): this pattern-matching is not exhaustive.
# Here is an example of a case that is not matched:
# Float16
@kit-ty-kate
Copy link
Author

Update: beta1 got released today

@zshipko
Copy link
Owner

zshipko commented Mar 25, 2024

Thanks, for the reminder - I will try to publish a new version this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants