Command got signal SEGV.

[mimoo]

I'm getting the error in the title at the moment, and I see that I'm the first one talking about that in the issues :D hopefully I'll find some solution that will help the next guy.

[mimoo]

I'm wondering if it could be that I implement FromValue on references on my custom types:

        unsafe impl<'a> ocaml::FromValue<'a> for &$name {
            fn from_value(value: ocaml::Value) -> Self {
                let x: ocaml::Pointer<Self> = ocaml::FromValue::from_value(value);
                x.as_ref()
            }
        }

or if in the last stable version I still need to implement a finalizer to call drop (I was under the impression that we didn't have to do these anymore as it was the default, but maybe that's only in the beta since the tests use a finalizer on this repo at the tag of the latest stable)

[mimoo]

OK so I isolated the exported Rust function that was crashing (using lldb), and I changed the parameter from &MyOpaqueType to ocaml::Pointer<MyOpaqueType> and it works. I guess I need to implement FromValue on T and not &T

[mimoo]

it's kind of weird because to book actually works with references: https://zshipko.github.io/ocaml-rs/02_type_conversion.html (and it doesn't even have to implement FromValue, I'm guessing the last beta version implements it for you with custom!?)

[mimoo]

the examples in the tests seem to only use ocaml::Pointer<_> as arguments of functions as well

[zshipko]

Yeah, in the latest version FromValue is implemented for &T and &mut T where T: Custom:

ocaml-rs/src/custom.rs

Line 195 in cae584c

unsafe impl<T: Custom> FromValue for &T {

They use Pointer to do the conversion.

[mimoo]

do you know why I was getting this errors with that implementation?

unsafe impl<'a> ocaml::FromValue<'a> for &$name {
            fn from_value(value: ocaml::Value) -> Self {
                let x: ocaml::Pointer<Self> = ocaml::FromValue::from_value(value);
                x.as_ref()
            }
        }

in any case now things work by using ocaml::Pointer<_> everywhere, but I would have expected that to work : o