-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Weekday Ordinals #89
Comments
I would argue that it should be changed to be 0-6 or have a configuration to pick between 0-6 or 1-7 as right now if we wanted to use this crate we'd need to fork it and change it to 0-6. Otherwise, the crate looks great! |
See also: #37. Sunday=1 was taken from the Quartz service.
+1.
I can't do this as there are folks using it for parsing Quartz's flavor of cron expressions.
This would be great! There are other settings that would be nice to have, too. Off the top of my head:
I'd like to have a builder API that lets folks opt into these settings. Exposing a day-of-week ordinals option would be a good place to start. If anyone is interested in implementing that, let me know and we can sketch out what the API should look like. |
Hello, I'd also like to say this is a great crate! :-) |
Hi,
First of all, thanks for this great crate.
However, the numbering of weekdays seems unusual to me. On the machines I usually work, the crontab uses a 0 for Sunday, 1 for Monday and so on.
This crate seems to use
1
for Sunday and not accept0
.Maybe this should be documented somewhere.
The text was updated successfully, but these errors were encountered: