You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My understanding of the replace function on BackStack is that it should swap the item at the top of the stack, so if the routing is a,b,c and replace(d) is called it should become a,b,d.
However, the replace function uses .subList(0, elements.lastIndex - 1) which removes 2 elements (the second argument being exclusive).
This should probably either change to use size or remove the -1 (the latter makes more sense to me).
This is, of course, all invalid if I've misunderstood what replace is supposed to do.
The text was updated successfully, but these errors were encountered:
My understanding of the
replace
function onBackStack
is that it should swap the item at the top of the stack, so if the routing isa,b,c
andreplace(d)
is called it should becomea,b,d
.However, the replace function uses
.subList(0, elements.lastIndex - 1)
which removes 2 elements (the second argument being exclusive).This should probably either change to use
size
or remove the-1
(the latter makes more sense to me).This is, of course, all invalid if I've misunderstood what replace is supposed to do.
The text was updated successfully, but these errors were encountered: