Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override theme variables not working #26

Closed
mflilian opened this issue Nov 10, 2022 · 2 comments
Closed

Override theme variables not working #26

mflilian opened this issue Nov 10, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@mflilian
Copy link

mflilian commented Nov 10, 2022

Hey everyone!
I'm trying to override the theme variables such as: JOVIAL_SYMBOL and JOVIAL_PALETTE but unfortunately no success yet.

First I did what you recommended on symbols section, but then I got the following error assignment to invalid subscript range. After doing some researches I could fix this error by adding typeset -gA JOVIAL_SYMBOL before any assignments of JOVIAL_SYMBOL to reset the type (same thing for JOVIAL_PALETTE).
I'm currently not getting any error but the customization is not working, it's always getting jovial default values.

Here's my ~/.zshrc setting for it:

export ZSH="$HOME/.oh-my-zsh"

ZSH_THEME="jovial"

typeset -gA JOVIAL_SYMBOL
JOVIAL_SYMBOL[git.dirty]='✘'
JOVIAL_SYMBOL[arrow]='->'
JOVIAL_SYMBOL[arrow.git-clean]='->'
JOVIAL_SYMBOL[arrow.git-dirty]='->'

typeset -gA JOVIAL_PALETTE
JOVIAL_PALETTE[host]='%F{218}'
JOVIAL_PALETTE[user]='F{224}'
JOVIAL_PALETTE[root]='%B%F{204}'
JOVIAL_PALETTE[path]='%B%F{162}%}'
JOVIAL_PALETTE[git]='%F{198}'
JOVIAL_PALETTE[venv]='%F{212}'
JOVIAL_PALETTE[time]='%F{225}'

I don't really know what could it be, could you help me pls?
Thanks 🎀

@zthxxx
Copy link
Owner

zthxxx commented Nov 11, 2022

@mflilian hello, thanks for use this theme~

All of the override should be set after "load theme", with oh-my-zsh that's means the line source $ZSH/oh-my-zsh.sh in .zshrc.

image

@zthxxx zthxxx added the help wanted Extra attention is needed label Nov 11, 2022
@mflilian
Copy link
Author

@mflilian hello, thanks for use this theme~

All of the override should be set after "load theme", with oh-my-zsh that's means the line source $ZSH/oh-my-zsh.sh in .zshrc.

image

yeaaaah!!! ahhahahaha thank you so much 💟 it worked!!! I'm gonna close this issue and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants