Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude_files_in is always overwritten when passed as a parameter to RuleList. #32

Open
laurynmm opened this issue Feb 1, 2023 · 1 comment

Comments

@laurynmm
Copy link
Contributor

laurynmm commented Feb 1, 2023

In zulint/custom_rules.py, theoretically exclude_files_in can be passed as a parameter when creating a RuleList, but it's always set as "\\" no matter what string is passed as a parameter. See code block below.

I'm not sure what the intention was as exclude_files_in is not listed in the documentation comment "Rule help" as a way to exclude files. There's only one current instance of it's use in zulip/zulip, here.

class RuleList:
    """Defines and runs custom linting rules for the specified language."""

    def __init__(
        self,
        langs: Sequence[str],
        rules: Sequence[Rule],
        exclude_files_in: Optional[str] = None,
    ) -> None:
        self.langs = langs
        self.rules = rules
        # Exclude the files in this folder from rules
        self.exclude_files_in = "\\"
        self.verbose = False
@mks2002
Copy link

mks2002 commented Jun 5, 2023

is this still open I want to contribute on this, please assign me this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants