Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a stream web-public, in stream settings #5250

Closed
gnprice opened this issue Feb 18, 2022 · 1 comment · Fixed by #5389
Closed

Set a stream web-public, in stream settings #5250

gnprice opened this issue Feb 18, 2022 · 1 comment · Fixed by #5389
Labels
a-stream settings/subs Creating streams, subscribing, editing settings P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@gnprice
Copy link
Member

gnprice commented Feb 18, 2022 •
edited

This is a follow-up on #5014, which was for displaying when a stream is web-public.

In the stream settings screen (which you get to e.g. via the "info" icon in the app bar when looking at the stream narrow), we offer a switch to make the stream private or public.

We should add the option to make it web-public. This probably means replacing the boolean switch UI with a UI to choose from a list.

While we're at it, this is probably a good prompt to add the concept of private streams with shared history (vs. private streams with protected history): #2683. So it'll be a choice between four options:

  • web-public
  • public
  • private, shared history
  • private, protected history

See the corresponding UI in the web app for comparison. Note there's kind of a lot of text accompanying each option -- which is probably necessary, because distinctions like "public" vs "web-public", or "shared history" vs "protected history", are a bit subtle.
@gnprice gnprice added the webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. label Feb 18, 2022
@gnprice gnprice mentioned this issue Feb 18, 2022
Closed
@gnprice gnprice added the a-stream settings/subs Creating streams, subscribing, editing settings label Feb 18, 2022
@gnprice gnprice mentioned this issue Feb 18, 2022
Open
@Fingel Fingel self-assigned this Mar 8, 2022
@Fingel Fingel mentioned this issue Mar 9, 2022
Open
@Fingel Fingel mentioned this issue Mar 18, 2022
Closed
@gnprice gnprice added P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. labels Apr 14, 2022
This was referenced Apr 14, 2022
Merged
Merged
Merged
Merged
Merged
@chrisbobbe chrisbobbe mentioned this issue Apr 27, 2022
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 28, 2022
@chrisbobbe
StreamSettingsScreen: s/Private/Privacy/; use radio buttons, not a sw…
fc9cba4 
…itch

For zulip#5250, we'll need to let the user choose one among more than two
options. That'll call for a radio-button-style input, rather than a
switch.

So, make a new component InputRowRadioButtons, and use it for an
input labeled "Privacy", replacing the SwitchRow input labeled
"Private".

And, to support that component, write and wire up another new
component, SelectableOptionsScreen.
@chrisbobbe chrisbobbe mentioned this issue Apr 28, 2022
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 4, 2022
@chrisbobbe
StreamSettingsScreen: s/Private/Privacy/; use radio buttons, not a sw…
aef1f02 
…itch

For zulip#5250, we'll need to let the user choose one among more than two
options. That'll call for a radio-button-style input, rather than a
switch.

So, make a new component InputRowRadioButtons, and use it for an
input labeled "Privacy", replacing the SwitchRow input labeled
"Private".

And, to support that component, write and wire up another new
component, SelectableOptionsScreen.
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 10, 2022
@chrisbobbe
StreamSettingsScreen: s/Private/Privacy/; use radio buttons, not a sw…
9b9b90d 
…itch

For zulip#5250, we'll need to let the user choose one among more than two
options. That'll call for a radio-button-style input, rather than a
switch.

So, make a new component InputRowRadioButtons, and use it for an
input labeled "Privacy", replacing the SwitchRow input labeled
"Private".

And, to support that component, write and wire up another new
component, SelectableOptionsScreen.
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 10, 2022
@chrisbobbe
StreamSettingsScreen: s/Private/Privacy/; use radio buttons, not a sw…
5ceec85 
…itch

For zulip#5250, we'll need to let the user choose one among more than two
options. That'll call for a radio-button-style input, rather than a
switch.

So, make a new component InputRowRadioButtons, and use it for an
input labeled "Privacy", replacing the SwitchRow input labeled
"Private".

And, to support that component, write and wire up another new
component, SelectableOptionsScreen.
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 11, 2022
@chrisbobbe
StreamSettingsScreen: s/Private/Privacy/; use radio buttons, not a sw…
24dc7a4 
…itch

For zulip#5250, we'll need to let the user choose one among more than two
options. That'll call for a radio-button-style input, rather than a
switch.

So, make a new component InputRowRadioButtons, and use it for an
input labeled "Privacy", replacing the SwitchRow input labeled
"Private".

And, to support that component, write and wire up another new
component, SelectableOptionsScreen.
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 13, 2022
@chrisbobbe
StreamSettingsScreen: s/Private/Privacy/; use radio buttons, not a sw…
edf5322 
…itch

For zulip#5250, we'll need to let the user choose one among more than two
options. That'll call for a radio-button-style input, rather than a
switch.

So, make a new component InputRowRadioButtons, and use it for an
input labeled "Privacy", replacing the SwitchRow input labeled
"Private".

And, to support that component, write and wire up another new
component, SelectableOptionsScreen.
This was referenced May 20, 2022
Merged
Merged
@chrisbobbe
Copy link
Contributor

Closing as fixed by #5389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-stream settings/subs Creating streams, subscribing, editing settings P1 high-priority server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
None yet
Milestone
No milestone
3 participants
@gnprice @Fingel @chrisbobbe