Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamsReducer tests: Start type-checking; use example data #5339

Merged
merged 2 commits into from
Apr 15, 2022
Merged

streamsReducer tests: Start type-checking; use example data #5339

merged 2 commits into from
Apr 15, 2022

Conversation

chrisbobbe
Copy link
Contributor

@chrisbobbe chrisbobbe commented Apr 14, 2022 •
edited
Loading

On the path to a fix for #5250.

@chrisbobbe chrisbobbe requested a review from gnprice April 14, 2022 21:32
@chrisbobbe @gnprice
streamsReducer tests: Remove test for nonexistent email_address pro…
91cdc87 
…perty

This isn't a valid property of a stream, according to our Flow
types. Flow would normally complain, except that this is one of the
few files that doesn't have type-checking yet. We'll fix that next.
@chrisbobbe @gnprice
streamsReducer tests: Start type-checking; use example data
a1d5db7
@gnprice
Copy link
Member

gnprice commented Apr 15, 2022

Thanks! Looks good -- merging.

@gnprice gnprice merged commit a1d5db7 into zulip:main Apr 15, 2022
@chrisbobbe
Copy link
Contributor Author

Thanks!

@chrisbobbe chrisbobbe deleted the pr-streamsreducer-types branch April 15, 2022 21:45
@chrisbobbe chrisbobbe mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnprice gnprice Awaiting requested review from gnprice

Assignees
No one assigned
Labels
P1 high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisbobbe @gnprice