Remove 'Detox' and related files #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the Detox end-to-end testing library from the project. https://github.com/wix/Detox This was introduced in zulip#825 This is a heavy depenency and sometimes the 'yarn' command fails on installing it (noncritically, but still). Since we never made any use of it in the last 2 years (still a good idea, but still, not used) a good idea is to remove it.
|
Thanks @borisyankov -- merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Detox end-to-end testing library from the project.
https://github.com/wix/Detox
This was introduced in #825
This is a heavy depenency and sometimes the 'yarn' command fails on
installing it (noncritically, but still).
Since we never made any use of it in the last 2 years (still a good
idea, but still, not used) a good idea is to remove it.