lightbox: Download images with correct names and MIME types. #4140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
downloadImage
function saves images with thewrong names, extensions and MIME types. This commit fixes that
by introducing a new argument for the function -
fileName
,and by determining the MIME type from the file extension.
Simply having the proper extension does not fix the issue, as the file is still interpreted as a text file by Android. The proper MIME type is still required.
Fixes: #4138
Fixes: #4137