user [nfc]: Clean up naming and organization of new-PM screens #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
The old name was highly misleading about what this does. Not to mention the directory it was in -- Zulip user groups are completely unrelated to group-PM threads, which is what this screen is actually about.
There are lots of screens in the app that show users, or even all users. This screen in reality has a very specific role. Name it accordingly. Also move it next to the parallel NewGroupPmScreen component.
chrisbobbe
force-pushed
the
pr-new-pm-screens-cleanup
branch
from
0390f3a
to
b8e24c1
Compare
|
Thanks, LGTM! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #5506 (comment) .
user [nfc]: Inline "card" into trivial "screen" wrapper UsersScreen
user [nfc]: Rename NewGroupPmScreen from CreateGroupScreen
The old name was highly misleading about what this does.
Not to mention the directory it was in -- Zulip user groups are
completely unrelated to group-PM threads, which is what this screen
is actually about.
user [nfc]: Rename New1to1PmScreen from UsersScreen
There are lots of screens in the app that show users, or even
all users. This screen in reality has a very specific role.
Name it accordingly.
Also move it next to the parallel NewGroupPmScreen component.
user [nfc]: Have UserList get presence data, not callers