Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user [nfc]: Clean up naming and organization of new-PM screens #5540

Merged
merged 4 commits into from
Nov 10, 2022
Merged

user [nfc]: Clean up naming and organization of new-PM screens #5540

merged 4 commits into from
Nov 10, 2022

Commits on Nov 10, 2022

  1. user [nfc]: Inline "card" into trivial "screen" wrapper UsersScreen

    @gnprice @chrisbobbe
    gnprice authored and chrisbobbe committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    b20263b View commit details
    Browse the repository at this point in the history

  2. user [nfc]: Rename NewGroupPmScreen from CreateGroupScreen 

    The old name was highly misleading about what this does.

Not to mention the directory it was in -- Zulip user groups are
completely unrelated to group-PM threads, which is what this screen
is actually about.
    @gnprice @chrisbobbe
    gnprice authored and chrisbobbe committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    15373b1 View commit details
    Browse the repository at this point in the history

  3. user [nfc]: Rename New1to1PmScreen from UsersScreen 

    There are lots of screens in the app that show users, or even
all users.  This screen in reality has a very specific role.
Name it accordingly.

Also move it next to the parallel NewGroupPmScreen component.
    @gnprice @chrisbobbe
    gnprice authored and chrisbobbe committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    b84f9ee View commit details
    Browse the repository at this point in the history

  4. user [nfc]: Have UserList get presence data, not callers

    @gnprice @chrisbobbe
    gnprice authored and chrisbobbe committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    b8e24c1 View commit details
    Browse the repository at this point in the history