bugfix: Construct narrow appropriately before verifying and triggering footer notifications. #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the type of the `req` parameter in `test_notify_if_message_sent_outside_narrow` from a string of ', ' separated emails to a list of emails, consistent with the current type of the `to` attribute of PrivateComposition.
This commit fixes a bug that previously caused a "Message sent outside current narrow." message in the footer in group pms (huddles) even when on the right narrow. This happened because of the wrong separator being used, ','. This has been changed to the relevant separator - ', '. Test added.
neiljp
force-pushed
the
huddle_narrow_bug
branch
from
f2bfe59
to
44452f5
Compare
|
@prah23 Thanks for noticing and fixing this 👍 I adjusted the commit text to fit our style and be more descriptive (and the new test case id) and am merging now 🎉 |
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Structure:
refactor: tests: Change req parameter to use a list of recipient emails.
This commit refactors the test cases of the
reqparameter intest_notify_if_message_sent_outside_narrowfrom a string of ', 'separated emails to a list of emails, consistent with the current type
of the
toattribute of PrivateComposition.Tests updated.
bugfix: helper: Use ', ' as separator to construct narrow to verify.
This commit fixes a bug that previously caused a "Message sent outside
current narrow." message in the footer in group pms (huddles) even when
on the right narrow. This happened because of the wrong separator being
used, ','. This has been changed to the relevant separator - ', '.
Test added.
Testing and linting:
I've ran tests locally on each commit. I've also ran
blackchecks and then the more extensive./tools/lint-all.