Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate UI & Docs from Private to Direct phrasing #1322

Merged
merged 8 commits into from
Mar 21, 2023
Merged

Migrate UI & Docs from Private to Direct phrasing #1322

merged 8 commits into from
Mar 21, 2023

Commits on Mar 21, 2023

  1. messages: Rename 'private' to 'direct' in narrow titles and edit error. 

    This commit renames 'private messages' to 'direct messages' and
'private conversation' to 'direct message conversation' in narrow titles,
as well as when a user attempts to edit another user's direct message.

Tests updated.
    @theViz343 @neiljp
    theViz343 authored and neiljp committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    dd04047 View commit details
    Browse the repository at this point in the history

  2. tests: buttons: Add tests for PMButton button text and length.

    @theViz343 @neiljp
    theViz343 authored and neiljp committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0e26cd8 View commit details
    Browse the repository at this point in the history

  3. buttons: Rename 'private' to 'direct' in left sidebar button. 

    This commit renames 'Private messages' to 'Direct messages' in the left
sidebar menu button.

Test updated.
    @theViz343 @neiljp
    theViz343 authored and neiljp committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    bbed974 View commit details
    Browse the repository at this point in the history

  4. model: Rename 'private' to 'direct' in notifications. 

    This commit replaces the use of 'private' with 'direct' in
notifications when the user sets the 'Include content of direct
messages in desktop notifications' setting to False.

Test updated.
    @theViz343 @neiljp
    theViz343 authored and neiljp committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5533053 View commit details
    Browse the repository at this point in the history

  5. keys: Rename 'private' to 'direct' in hotkeys descriptions. 

    This commit renames 'private messages' to 'direct messages' in the
keys source file, affecting the in-application help menu.

hotkeys.md regenerated using lint-hotkeys.
    @theViz343 @neiljp
    theViz343 authored and neiljp committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    78254e5 View commit details
    Browse the repository at this point in the history

  6. README/docs: Rename 'private' to 'direct' in docs. 

    This commit replaces the use of 'private' with 'direct' in the docs.
It also removes instances of PM (abbreviation for private message)
following the change in zulip#1293.
    @theViz343 @neiljp
    theViz343 authored and neiljp committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f33b6a3 View commit details
    Browse the repository at this point in the history

  7. refactor: developer-file-overview: Reduce description column width. 

    The maximum docstring length was reduced in 5745272, but the overview file
was not regenerated at that point, so the column width in the document was
not updated.

Therefore, this regenerates the file to make updating of docstrings clearer
later.
    @theViz343 @neiljp
    theViz343 authored and neiljp committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    38d5a1c View commit details
    Browse the repository at this point in the history

  8. buttons: Replace 'private' to 'direct' in file docstring. 

    developer-file-overview.md regenerated using lint-docstring.
    @theViz343 @neiljp
    theViz343 authored and neiljp committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    9e066bc View commit details
    Browse the repository at this point in the history