Improve styling for /digest page

[timabbott]

The /digest page (see #9974) is primarily for development/testing of Zulip's digest emails, but even so, it'd be great to restructure it to have a container around the email body, centering it, etc. Might be able to borrow some logic from the /emails page for this.

[zulipbot]

Hello @zulip/server-development members, this issue was labeled with the "area: emails" label, so you may want to check it out!

[Shoumorup]

@zulipbot claim

[Shoumorup]

Hey @timabbott ! Just a few trivial questions.
This issue essentially wants to address that:

1. All hard-coded css presently in templates/zerver/emails/compiled/digest.html be removed to a separate digest.css file (Similar to email.css)?
   This digest.css file be called from another python script similar to tools/inline-email-css?

OR
2. Is it just a correction of the css in the templates/zerver/emails/compiled/digest.html file so that it'd look a bit better?

I'm confused because i'm referring to /emails which uses templates/zerver/email_log.html which is more of a dev experience while "digest.html" should be more of an user experience (I'm presuming). I personally feel that correcting the css in digest.html should do as the file is already using email.css through inline-email-css.

Is this correct or you aim to address something else that i might be missing?

Sorry for the constant nagging

[Shoumorup]

@timabbott Can you please review it?
https://github.com/zulip/zulip/pull/11095

[hackerkid]

@Shoumorup

All hard-coded css presently in templates/zerver/emails/compiled/digest.html be removed to a separate digest.css file (Similar to email.css)?

So digest.html is generated automatically from templates/zerver/emails/digest.source.html while running ./tools/inline-email-css. You dont have to seperate the CSS again. The CSS is seperated and already stored in templates/zerver/emails/email.csss

The issue is about improving the /digest page. By improving /digest page it means to improve how the digest email is displayed in /digest page and not the content of digest email. So dont make any changes to digest.source.html, digest.html, email.css etc.

zerver/views/digest.py has the view which handles /digest page. Currently it just returns digest.html as the response. You need to make the styling look similiar to /emails page. For that you have to probably display the content of digest.html in another template. See email_log.html for example. The content is passed to email_log.html as variable log. In your case the content would be the rendered digest.html email in zerver/views/digest.py. If you have any further doubts ask in chat.zulip.org.

[Shoumorup]

https://github.com/zulip/zulip/pull/11147

@timabbott @hackerkid Do you want anything really fancy or minimalistic? Is it required to add a link in the alert that would take the person back to the intended conversation page from the /digest page?

Does the simple "include" of zerver/emails/compiled/digest.html seem okay or do you want to similar to the "log" manner in which email_content.log renders it's content?

[hackerkid]

@Shoumorup You don't want to add any extra features.

The /digest page (see #9974) is primarily for development/testing of Zulip's digest emails, but even so, it'd be great to restructure it to have a container around the email body, centering it, etc.

Focus only on this. If you compare the /emails and /digest page its obvious that the styling looks kind of broken in /digest page. You just have to make it look better without touching the styling of the actual email aka email.css :)

[timabbott]

@jmandel FYI this is now a way one can see the what the digest emails look like for iterating on the content, which I recall was an FHIR request.