Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling for digest page #11095

Closed
wants to merge 1 commit into from
Closed

Conversation

Shoumorup
Copy link
Collaborator

@Shoumorup Shoumorup commented Dec 20, 2018

This is with respect to issue #11016 (#11016)

GIFs or Screenshots: <!-- If a UI change. See:
https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html

digest

@timabbott
Copy link
Sponsor Member

@Shoumorup so, I'm worried you've misunderstood the issue; this looks like this substanstially changes the styling of the digest emails themselves. We don't want to do that directly before we apply the inline-email-css infrastructure to that email (which I think @hackerkid has a PR that needs finishing for). #11016 was about applying externals CSS to the /digest page (which is supposed to display the email) to put it inside a centered container to look nicer.

@hackerkid
Copy link
Member

I have left a comment in #11016 which has some technical details on how this should be done.

@zulipbot
Copy link
Member

Heads up @Shoumorup, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants