Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivate organization button is not disabled for regular users #16080

Closed
Gittenburg opened this issue Aug 9, 2020 · 14 comments
Closed

Deactivate organization button is not disabled for regular users #16080

Gittenburg opened this issue Aug 9, 2020 · 14 comments
Labels
area: settings (admin/org) bug good first issue

Comments

@Gittenburg
Copy link
Collaborator

Gittenburg commented Aug 9, 2020 •
edited
Loading

Can be reproduced at https://chat.zulip.org/#organization/organization-profile.

I think this is a regression ... I remember the button being disabled before.
@zulipbot
Copy link
Member

zulipbot commented Aug 9, 2020

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

@timabbott
Copy link
Sponsor Member

Yeah agreed it's a regression.

@Jagansivam28
Copy link
Collaborator

@zulipbot claim

Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
4dbfca9 
We need to disable the deactivate organization button all other users
other than owner But currently, we are showing deactivate button for
regular users also. This commit fixes the bug.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
3715e7b 
We need to disable the deactivate organization button all other users
other than owner But currently, we are showing deactivate button for
regular users also. This commit fixes the bug.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
9b35490 
We need to disable the deactivate organization button all other users
other than owner But currently, we are showing deactivate button for
regular users also. This commit fixes the bug.
fixes zulip#16080
@Jagansivam28 Jagansivam28 mentioned this issue Aug 11, 2020
Closed
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
a932c39 
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
9a3e41b 
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing `[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’ as a property, not an attribute.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
e8ead79 
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing
`[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’
as a property, not an attribute.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 14, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
1fff39e 
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing
`[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’ as a property, not an attribute.
Fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 25, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
8b92154 
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing
`[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’ as a property, not an attribute.
Fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 26, 2020
@Jagansivam28
UI: Fix deactivate organization button bug.
b144319 
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing
`[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’ as a property, not an attribute.
Fixes zulip#16080
@zulipbot
Copy link
Member

zulipbot commented Sep 8, 2020 •
edited
Loading

Hello @Jagansivam28, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@jakharrahul000
Copy link

Hi @timabbott and @Gittenburg, I am new to this community and was looking to contribute.
I saw the issue, and it seems the button is already disabled, it does nothing on click, however it does change the color of the button, if you are addressing that.

@ligmitz
Copy link
Collaborator

ligmitz commented Oct 12, 2020

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @ligmitz! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@ligmitz ligmitz mentioned this issue Oct 13, 2020
Closed
@ligmitz ligmitz removed their assignment Jan 23, 2021
@mgshestko
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Feb 3, 2021

Welcome to Zulip, @mgshestko! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@mgshestko
Copy link
Collaborator

mgshestko commented Feb 14, 2021 •
edited
Loading

After carefully reviewing my assigned bug, I’ve determined that it’s been fixed by two earlier submission report.
#16104 fixes the UI issues and #16524 fixes the hover issue.

My open pull request should be closed.

How should I proceed? @timabbott

@zulipbot
Copy link
Member

zulipbot commented Mar 7, 2021

Hello @mgshestko, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

@mgshestko
Copy link
Collaborator

@zulipbot abandon

@asah
Copy link
Collaborator

asah commented Dec 22, 2021

@Gittenburg cannot reproduce?

image

@alya
Copy link
Contributor

alya commented Jun 5, 2023

Closing as no longer reproducible (probably resolved).

@alya alya closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: settings (admin/org) bug good first issue
Projects
None yet
Milestone
No milestone
9 participants
@asah @alya @timabbott @zulipbot @jakharrahul000 @Jagansivam28 @Gittenburg @ligmitz @mgshestko