Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration page buttons formatted badly in some languages #20563

Closed
alya opened this issue Dec 14, 2021 · 11 comments · Fixed by #29622 · May be fixed by #20578
Closed

Registration page buttons formatted badly in some languages #20563

alya opened this issue Dec 14, 2021 · 11 comments · Fixed by #29622 · May be fixed by #20578

Comments

@alya
Copy link
Contributor

alya commented Dec 14, 2021

The /register page buttons aren't formatted properly when the text is long. E.g. in Russian:

Screen Shot 2021-12-13 at 10 13 09 PM

The Russian text happens to fit on one line on the /login page, but we should confirm that those buttons are fixed as well when we fix these ones.

@zulipbot
Copy link
Member

Hello @zulip/server-i18n, @zulip/server-onboarding members, this issue was labeled with the "area: i18n", "area: onboarding" labels, so you may want to check it out!

@atharvabhatt200
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @atharvabhatt200! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Jan 14, 2022

Hello @atharvabhatt200, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@shatabdi-pal
Copy link

Hello,
I am Shatabdi Pal. I am interested in working on this issue.

@shatabdi-pal
Copy link

@zulipbot claim I am Shatabdi Pal. I am interested in working on this issue.

@zulipbot
Copy link
Member

Welcome to Zulip, @shatabdi-pal! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Apr 8, 2022

Hello @shatabdi-pal, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@alya alya changed the title Registration page buttons formatted badly in some langauges Registration page buttons formatted badly in some languages Mar 13, 2024
@josesantoscorte
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Apr 4, 2024

Welcome to Zulip, @josesantoscorte! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

josesantoscorte added a commit to josesantoscorte/zulip that referenced this issue Apr 4, 2024
Fiexes issue zulip#20563 of text overlapping in registration buttons
josesantoscorte added a commit to josesantoscorte/zulip that referenced this issue Apr 4, 2024
This ensures that in the registration page the text does not overlap icons in any language.

Fixes zulip#20563.
@amanagr
Copy link
Member

amanagr commented Apr 10, 2024

Closing as fixed in #23258

@amanagr amanagr closed this as completed Apr 10, 2024
timabbott pushed a commit that referenced this issue Apr 12, 2024
This ensures that in the registration page the text does not overlap icons in any language.

Fixes #20563.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment