Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show no search result message in filter stream search #20797

Open
Biki-das opened this issue Jan 14, 2022 · 9 comments
Open

Show no search result message in filter stream search #20797

Biki-das opened this issue Jan 14, 2022 · 9 comments
Assignees
Labels
area: left sidebar (logic & sorting) Left sidebar business logic and sorting area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers help wanted in progress

Comments

@Biki-das
Copy link
Collaborator

Biki-das commented Jan 14, 2022

currently in the search stream filter, if there are no matching streams found, it does not show anything, it will be better to show message stating no stream found

announce - Zulip Dev - Zulip - Google Chrome 14-01-2022 2 03 46 PM

this is what it should look like

announce - Zulip Dev - Zulip - Google Chrome 14-01-2022 1 59 54 PM

Biki-das added a commit to Biki-das/zulip that referenced this issue Jan 14, 2022
This PR adds a logic check, if the count of length of elems is less than 1, it shows a message.
Fixes-zulip#20797.
@Biki-das
Copy link
Collaborator Author

@alya feedback apppreciated, thanks

@alya
Copy link
Contributor

alya commented Jan 20, 2022

Good idea! Let's change the string to "No matching streams.", to be parallel with the "No matching users." string in the right sidebar.

Just to confirm, I assume you used the same font as we have for "No matching users."?

@Biki-das
Copy link
Collaborator Author

Good idea! Let's change the string to "No matching streams.", to be parallel with the "No matching users." string in the right sidebar.

Just to confirm, I assume you used the same font as we have for "No matching users."?

yeah sure

@karlstolley karlstolley added area: left sidebar (logic & sorting) Left sidebar business logic and sorting area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers and removed area: left sidebar (misc) labels Sep 19, 2023
@oneshikaa
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @oneshikaa! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Oct 24, 2023

@oneshikaa You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@cynthialiuu
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @cynthialiuu! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@Faten-toujani
Copy link

code issue.pdf

this identified some style and dependency issues. what we need to correct is : resolving the CSS color function, running Prettier to fix formatting, and refactoring code to eliminate circular dependencies. :
1 - Problem: The code uses an outdated way to specify colors in CSS.
Solution:
Locate line 105, column 12 in : " web/styles/left_sidebar.css "
Identify the outdated color function (e.g., rgb(255, 0, 0)).
Replace it with a modern color function, such as:
Hexadecimal notation: #( the code of color )

2- Prettier : The code doesn't follow consistent style guidelines.
Solution:
Run the command: " ./tools/lint --fix"

3- ESLint - Import Order : "./stream_list " is imported after " ./user_settings, "but should be imported before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: left sidebar (logic & sorting) Left sidebar business logic and sorting area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers help wanted in progress
Projects
None yet
Development

No branches or pull requests

7 participants