New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show no search result
message in filter stream search
#20797
Comments
This PR adds a logic check, if the count of length of elems is less than 1, it shows a message. Fixes-zulip#20797.
@alya feedback apppreciated, thanks |
Good idea! Let's change the string to "No matching streams.", to be parallel with the "No matching users." string in the right sidebar. Just to confirm, I assume you used the same font as we have for "No matching users."? |
yeah sure |
@zulipbot claim |
Welcome to Zulip, @oneshikaa! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
@oneshikaa You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
@zulipbot claim |
Welcome to Zulip, @cynthialiuu! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
this identified some style and dependency issues. what we need to correct is : resolving the CSS color function, running Prettier to fix formatting, and refactoring code to eliminate circular dependencies. : 2- Prettier : The code doesn't follow consistent style guidelines. 3- ESLint - Import Order : "./stream_list " is imported after " ./user_settings, "but should be imported before. |
currently in the search stream filter, if there are no matching streams found, it does not show anything, it will be better to show message stating
no stream found
this is what it should look like
The text was updated successfully, but these errors were encountered: