Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20797: Added "No Matching Streams." when no result is found. #29867

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cynthialiuu
Copy link
Collaborator

When users search for a stream that doesn't exist, 'No matching strea…ms.' will appear. This maintains consistency with the user search, which shows 'No matching users.' and improves the UI of the search feature.

Fixes: Show no search result message in filter stream search #20797

Tooling tips: https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html
-->

Screenshots and screen captures:

Screenshot 2024-04-26 at 5 43 19 PM
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

…ms.' will appear. This maintains consistency with the user search, which shows 'No matching users.' and improves the UI of the search feature.
@alya
Copy link
Contributor

alya commented Apr 27, 2024

Thanks! Please clean up your commit history and post again to request a review. See here for guidelines.

You will also need to make sure your PR passes tests.

@Faten-toujani
Copy link

Faten-toujani commented Apr 29, 2024

code issue.pdf

this identified some style and dependency issues. what we need to correct is : resolving the CSS color function, running Prettier to fix formatting, and refactoring code to eliminate circular dependencies. :
1 - Problem: The code uses an outdated way to specify colors in CSS.
Solution:
Locate line 105, column 12 in : " web/styles/left_sidebar.css "
Identify the outdated color function (e.g., rgb(255, 0, 0)).
Replace it with a modern color function, such as:
Hexadecimal notation: #( the code of color )
You can refer to this website: https://www.rgbtohex.net/

2- ESLint - Import Order : "./stream_list " is imported after " ./user_settings, "but should be imported before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants