Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API support for using "direct" as the message "type" for private messages #24960

Closed
timabbott opened this issue Apr 3, 2023 · 3 comments · Fixed by #25154
Closed

Add API support for using "direct" as the message "type" for private messages #24960

timabbott opened this issue Apr 3, 2023 · 3 comments · Fixed by #25154
Assignees
@laurynmm
Labels
area: api difficult Issues which we expect to be quite difficult in progress priority: high release goal We'd like to resolve this for the current major release

Comments

@timabbott
Copy link
Sponsor Member

Since we renamed "private messages" to "direct messages" in the UI, we should start thinking about API changes in line with this change. This issue is for the simplest one, which I think should be a Zulip 7.0 release goal: Allowing send_message (and similar things like typing notifications requests) to use direct rather than private for the type parameter.

message_type_name: str = REQ("type")

@laurynmm can I assign this to you? git grep private zerver/views/ suggests it may just be those two endpoints that need attention here.

There's a significantly more difficult project of supporting a direct message type in events, which likely requires a client capability; the goal for this issue is just do the (mostly documentation, I think?) part of allowing things that send messages via the API to use the new name.
@timabbott timabbott added area: api priority: high difficult Issues which we expect to be quite difficult release goal We'd like to resolve this for the current major release labels Apr 3, 2023
@zulipbot
Copy link
Member

zulipbot commented Apr 3, 2023

Hello @zulip/server-api members, this issue was labeled with the "area: api" label, so you may want to check it out!

@laurynmm
Copy link
Collaborator

laurynmm commented Apr 3, 2023

@timabbott - Yeah, assigning to me makes sense. I already noted this down as a follow-up in the work I'm doing on #24806.

@laurynmm laurynmm self-assigned this Apr 4, 2023
@zulipbot
Copy link
Member

@laurynmm We noticed that you have not made any updates to this issue or linked PRs for 10 days. Please comment here if you are still actively working on it. Otherwise, we'd appreciate a quick @zulipbot abandon comment so that someone else can claim this issue and continue from where you left off.

If we don't hear back, you will be automatically unassigned in 4 days. Thanks!

laurynmm added a commit to laurynmm/zulip that referenced this issue Apr 17, 2023
@laurynmm
message-type: Add support for "direct" as value for type parameter.
334cd42 
For endpoints with a `type` parameter to indicate whether the message
is a stream or direct  message, `POST /typing` and `POST /messages`,
adds support for passing "direct" as a value for direct messages.

Maintains support for "private" as a deprecated alias for direct
messages.

Fixes zulip#24960.
laurynmm added a commit to laurynmm/zulip that referenced this issue Apr 17, 2023
@laurynmm
message-type: Add support for "direct" as value for type parameter.
e37f7f1 
For endpoints with a `type` parameter to indicate whether the message
is a stream or direct  message, `POST /typing` and `POST /messages`,
adds support for passing "direct" as a value for direct messages.

Maintains support for "private" as a deprecated alias for direct
messages.

Fixes zulip#24960.
laurynmm added a commit to laurynmm/zulip that referenced this issue Apr 17, 2023
@laurynmm
message-type: Add support for "direct" as value for type parameter.
577aa1f 
For endpoints with a `type` parameter to indicate whether the message
is a stream or direct message, `POST /typing` and `POST /messages`,
adds support for passing "direct" as a value for direct messages.

Maintains support for "private" as a deprecated alias for direct
messages.

Fixes zulip#24960.
@laurynmm laurynmm mentioned this issue Apr 17, 2023
Merged
12 tasks
laurynmm added a commit to laurynmm/zulip that referenced this issue Apr 18, 2023
@laurynmm
message-type: Add support for "direct" as value for type parameter.
2f3532b 
For endpoints with a `type` parameter to indicate whether the message
is a stream or direct message, `POST /typing` and `POST /messages`,
adds support for passing "direct" as the preferred value for direct
messages, group and 1-on-1.

Maintains support for "private" as a deprecated value to indicate
direct messages.

Fixes zulip#24960.
timabbott pushed a commit that referenced this issue Apr 18, 2023
@laurynmm @timabbott
message-type: Add support for "direct" as value for type parameter.
2c043c6 
For endpoints with a `type` parameter to indicate whether the message
is a stream or direct message, `POST /typing` and `POST /messages`,
adds support for passing "direct" as the preferred value for direct
messages, group and 1-on-1.

Maintains support for "private" as a deprecated value to indicate
direct messages.

Fixes #24960.
@laurynmm laurynmm mentioned this issue Apr 24, 2023
Open
ziyanwang1 pushed a commit to ziyanwang1/zulip that referenced this issue Apr 24, 2023
@laurynmm @ziyanwang1
message-type: Add support for "direct" as value for type parameter.
b4e47b3 
For endpoints with a `type` parameter to indicate whether the message
is a stream or direct message, `POST /typing` and `POST /messages`,
adds support for passing "direct" as the preferred value for direct
messages, group and 1-on-1.

Maintains support for "private" as a deprecated value to indicate
direct messages.

Fixes zulip#24960.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurynmm laurynmm

Labels
area: api difficult Issues which we expect to be quite difficult in progress priority: high release goal We'd like to resolve this for the current major release
Projects
No open projects
7.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

message-type: Add support for "direct" as value for type parameter. laurynmm/zulip
3 participants
@timabbott @zulipbot @laurynmm