Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp column should have a calculated width #26970

Closed
alya opened this issue Oct 2, 2023 · 16 comments · Fixed by #29501
Closed

Timestamp column should have a calculated width #26970

alya opened this issue Oct 2, 2023 · 16 comments · Fixed by #29501
Labels
area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) bug design help wanted priority: high

Comments

@alya
Copy link
Contributor

alya commented Oct 2, 2023

At present, the timestamp column can have different width for different times, causing alignment problems for other components (discussed here). Note well that different locales have very different time representations, so any complete calculated solution must work regardless of locale, language, and 12/24-hour time.

Screenshot-2023-10-02-at-11 32 21AM

Strategy for fixing this:

I think ideally we’d take some dummy time or collection of times that we expect to be widest, format it for the current locale, render it in a hidden div, ask the browser for its width, and put the width in a CSS variable.

CZO thread 1
CZO thread 2

@alya alya added bug help wanted priority: high area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) design labels Oct 2, 2023
@zulipbot
Copy link
Member

zulipbot commented Oct 2, 2023

Hello @zulip/design members, this issue was labeled with the "design" label, so you may want to check it out!

@karlstolley karlstolley changed the title Timestamp column should have fixed width Timestamp column should have a calculated width Oct 2, 2023
@TejasGoyal0
Copy link
Collaborator

@zulipbot claim

@aryan-bhokare
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Oct 2, 2023

Welcome to Zulip, @aryan-bhokare! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@himanshuaggar
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Oct 3, 2023

@himanshuaggar This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks!

@aryan-bhokare
Copy link
Collaborator

aryan-bhokare commented Oct 6, 2023

I think this issues has been already solved.
@zulipbot abandon

@alya maybe you can close this issue.

@alya
Copy link
Contributor Author

alya commented Oct 6, 2023

@aryan-bhokare Why do you say that? I don't see any merged PRs linked to this issue.

@aryan-bhokare
Copy link
Collaborator

I am very sorry. Maybe I misunderstood something else.
I read this CZO and thought it is solved.
But the timestamp width issue is still not fixed.

@arnavchhokra
Copy link
Collaborator

@zulipbot claim

arnavchhokra added a commit to arnavchhokra/zulip that referenced this issue Oct 6, 2023
This commit addresses issue zulip#26970, where the Timestamp column was not dynamically calculating its width, causing layout issues in the UI.

Previously, the Timestamp column had a fixed width, which led to improper alignment and display problems in certain cases. With this change, we ensure that the Timestamp column adapts its width dynamically based on the content, providing a more consistent and visually pleasing user experience.

This fix resolves the issue reported and improves the overall layout of the UI.

Fixes zulip#26970
@arnavchhokra
Copy link
Collaborator

Hi, please review this PR #27098

@aryan-bhokare
Copy link
Collaborator

Hi @alya can you please review the PR #27166 !

@zulipbot
Copy link
Member

zulipbot commented Oct 22, 2023

@arnavchhokra You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@andre-foliveira256
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @andre-foliveira256! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Mar 29, 2024

@andre-foliveira256 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

karlstolley added a commit to karlstolley/zulip that referenced this issue Mar 29, 2024
karlstolley added a commit to karlstolley/zulip that referenced this issue Mar 29, 2024
karlstolley added a commit to karlstolley/zulip that referenced this issue Mar 29, 2024
karlstolley added a commit to karlstolley/zulip that referenced this issue Apr 2, 2024
timabbott pushed a commit to timabbott/zulip that referenced this issue Apr 2, 2024
karlstolley added a commit to karlstolley/zulip that referenced this issue Apr 2, 2024
karlstolley added a commit to karlstolley/zulip that referenced this issue Apr 2, 2024
timabbott pushed a commit to timabbott/zulip that referenced this issue Apr 3, 2024
timabbott pushed a commit to karlstolley/zulip that referenced this issue Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) bug design help wanted priority: high
Projects
Status: Done
7 participants