Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26970: Timestamp column width calculation and UI layout #27098

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

arnavchhokra
Copy link
Collaborator

Description

This pull request addresses issue #26970, which reported a problem with the Timestamp column in the user interface. The Timestamp column was not dynamically calculating its width, resulting in layout issues.

Changes Made

  • Fixed the Timestamp column to dynamically calculate its width based on content.
  • Improved the UI layout by ensuring proper alignment of the Timestamp column.

Screenshots

image
image

Please review and merge this pull request to address the reported issue and enhance the UI layout.

This commit addresses issue zulip#26970, where the Timestamp column was not dynamically calculating its width, causing layout issues in the UI.

Previously, the Timestamp column had a fixed width, which led to improper alignment and display problems in certain cases. With this change, we ensure that the Timestamp column adapts its width dynamically based on the content, providing a more consistent and visually pleasing user experience.

This fix resolves the issue reported and improves the overall layout of the UI.

Fixes zulip#26970
@zulipbot zulipbot added size: XS area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) bug design priority: high labels Oct 6, 2023
@zulipbot
Copy link
Member

zulipbot commented Oct 6, 2023

Hello @zulip/design members, this pull request was labeled with the "design" label, so you may want to check it out!

@alya
Copy link
Contributor

alya commented Oct 11, 2023

Please clean up your commit history and post again to request a review. See here for guidelines.

@alya
Copy link
Contributor

alya commented Oct 11, 2023

You will also need to fill out the self-review checklist.

@arnavchhokra
Copy link
Collaborator Author

okay

@zulipbot
Copy link
Member

zulipbot commented Apr 4, 2024

Heads up @arnavchhokra, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) bug design has conflicts priority: high size: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants