Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unknown user avatar (for limited guests) work on mobile #28071

Closed
alya opened this issue Dec 6, 2023 · 2 comments
Closed

Make unknown user avatar (for limited guests) work on mobile #28071

alya opened this issue Dec 6, 2023 · 2 comments
Assignees
@sahil839
Labels
area: settings (admin/org) in progress

Comments

@alya
Copy link
Contributor

alya commented Dec 6, 2023

As @gnprice reported on CZO:

I've tested the current implementation against the mobile app, now that #27544 and then #27873 have made it possible to test. Details here but in short there's just one incompatibility I found:

Zulip's system of avatar URLs is a bit complicated, and the current implementation doesn't quite follow it faithfully for the static "unknown user" avatar image. The result is that in some places we fail to show the avatar, and show a blank space instead.

The proposed solution is changing the server to add a symlink to offer the same file at the -medium.png.

CZO thread
@zulipbot
Copy link
Member

zulipbot commented Dec 6, 2023

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

sahil839 added a commit to sahil839/zulip that referenced this issue Dec 8, 2023
@sahil839
static: Make unknown user avatar work on mobile.
ee00e8d 
Clients like mobile add "-medium.png" to the url to get the
medium avatar if the avatar_url field of user object is set
to some string other than the gravatar URL.

This commit adds a symlink to offer the unknown user avatar at
unknown-user-avatar-medium.png as well so that mobile clients
can correctly render the medium avatars for inaccessible users.

Fixes zulip#28071.
timabbott pushed a commit to sahil839/zulip that referenced this issue Dec 9, 2023
@sahil839 @timabbott
static: Make unknown user avatar work on mobile.
a8aaee0 
Clients like mobile add "-medium.png" to the url to get the
medium avatar if the avatar_url field of user object is set
to some string other than the gravatar URL.

This commit adds a symlink to offer the unknown user avatar at
unknown-user-avatar-medium.png as well so that mobile clients
can correctly render the medium avatars for inaccessible users.

Fixes zulip#28071.
timabbott pushed a commit to sahil839/zulip that referenced this issue Dec 10, 2023
@sahil839 @timabbott
static: Make unknown user avatar work on mobile.
ec907a2 
Clients like mobile add "-medium.png" to the url to get the
medium avatar if the avatar_url field of user object is set
to some string other than the gravatar URL.

This commit adds a symlink to offer the unknown user avatar at
unknown-user-avatar-medium.png as well so that mobile clients
can correctly render the medium avatars for inaccessible users.

Fixes zulip#28071.
afeefuddin pushed a commit to afeefuddin/zulip that referenced this issue Dec 12, 2023
@sahil839 @afeefuddin
static: Make unknown user avatar work on mobile.
d2e0ec6 
Clients like mobile add "-medium.png" to the url to get the
medium avatar if the avatar_url field of user object is set
to some string other than the gravatar URL.

This commit adds a symlink to offer the unknown user avatar at
unknown-user-avatar-medium.png as well so that mobile clients
can correctly render the medium avatars for inaccessible users.

Fixes zulip#28071.
@chrisbobbe
Copy link
Contributor

Confirmed this is fixed in zulip-mobile. With a dev server at 53f4013, the picture appears whether we're requesting the small or the large size:

Large Small
1D948DF9-F564-484A-BD4B-F7EF3528A6D2 B4939985-7F87-40B0-8C84-92AB41D67F48

@chrisbobbe chrisbobbe mentioned this issue Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahil839 sahil839

Labels
area: settings (admin/org) in progress
Projects
No open projects
Zulip Server 8.0 priorities
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alya @chrisbobbe @zulipbot @sahil839