Add support to update can_access_all_users_group setting in dev environment.
#27873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-arranges the settings in "Organization permissions" section - - A new section "Guests" is added which now contains the guest indicator setting checkbox. - Moved "User identity" and "Guests" sections above "Other permissions" section.
This commit updates the backend code to allow changing can_access_all_users_group setting in development environment and also adds a dropdown in webapp UI which is only shown in development environment.
sahil839
commented
Nov 23, 2023
| @@ -232,6 +233,10 @@ def update_realm( | |||
| if enable_spectator_access: | |||
| realm.ensure_not_on_limited_plan() | |||
|
|
|||
| if can_access_all_users_group_id is not None: | |||
| # Remove this when the feature is ready for production. | |||
| assert settings.DEVELOPMENT | |||
There was a problem hiding this comment.
I have used assert here instead of raising JsonableErrror since we do the same for demo orgs feature.
timabbott
reviewed
Nov 23, 2023
| }, | ||
| }); | ||
| settings_components.set_can_access_all_users_group_widget(can_access_all_users_group_widget); | ||
| can_access_all_users_group_widget.setup(); |
There was a problem hiding this comment.
This isn't a task for this PR, but as a follow-up, we should work to make this a component where one can just pass in the setting name and it'll initialize everything; or maybe even a fancier version where one can declare it just via including the right block in an HTML template.
There was a problem hiding this comment.
Yeah, I was also thinking of doing something similar, would be needed especially when we would add more group-based settings.
|
Merged, thanks @sahil839! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can_access_all_users_groupsetting.Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: