Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compose expand/collapse button into text area #28791

Closed
Tracked by #24878
alya opened this issue Feb 1, 2024 · 8 comments · Fixed by #29683
Closed
Tracked by #24878

Move compose expand/collapse button into text area #28791

alya opened this issue Feb 1, 2024 · 8 comments · Fixed by #29683
Assignees
Labels
area: compose (misc) in progress redesign Part of the webapp redesign project, including blockers.

Comments

@alya
Copy link
Contributor

alya commented Feb 1, 2024

As part of the compose box redesign, we should move the compose expand/collapse button into the text area.

image

This issue is part of #24878.


Live demo with the source code on Repl.it. Here is the decomposed source code archive:
compose-decomposed.zip

The css code is split to decomposed areas but all the js code is in a single file. The file isn't big so it is easier to follow the logic of interactions between html and js.

@alya alya added area: compose (misc) redesign Part of the webapp redesign project, including blockers. labels Feb 1, 2024
@zulipbot
Copy link
Member

zulipbot commented Feb 1, 2024

Hello @zulip/design members, this issue was labeled with the "redesign" label, so you may want to check it out!

This was referenced Feb 1, 2024
@zulipbot
Copy link
Member

zulipbot commented Feb 2, 2024

Hello @notlelouch!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@ASHUVINAYAK1
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @ASHUVINAYAK1!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@Thanush19
Copy link
Collaborator

hey @alya , if the issue is not resolved ,i can work on this

@Faten-toujani
Copy link

hello , if the issue is not resolved yet ,i can work on this

@N-Shar-ma
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @N-Shar-ma!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 11, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose box (textarea).
To make space 20px extra padding is added to the right of the compose
box. It appears only on hovering the compose area, and uses a new custom
icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 12, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose box (textarea).
To make space 20px extra padding is added to the right of the compose
box. It appears only on hovering the compose area, and uses a new custom
icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 12, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose box (textarea).
To make space 20px extra padding is added to the right of the compose
box. It appears only on hovering the compose area, and uses a new custom
icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 22, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 23, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 23, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 24, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 27, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Apr 30, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue May 1, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue May 1, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: zulip#28791.
timabbott pushed a commit that referenced this issue May 2, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: #28791.
timabbott pushed a commit that referenced this issue May 3, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: #28791.
timabbott pushed a commit that referenced this issue May 3, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: #28791.
timabbott pushed a commit that referenced this issue May 6, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: #28791.
timabbott pushed a commit that referenced this issue May 7, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the textarea / preview, and uses a new custom icon.

Fixes: #28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue May 13, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue May 13, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue May 13, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Jun 3, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Jun 4, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: zulip#28791.
N-Shar-ma added a commit to N-Shar-ma/zulip that referenced this issue Jun 5, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: zulip#28791.
timabbott pushed a commit to timabbott/zulip that referenced this issue Jun 10, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: zulip#28791.
timabbott pushed a commit that referenced this issue Jun 10, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: #28791.
timabbott pushed a commit that referenced this issue Jun 11, 2024
The compose expand / collapse button is moved from the top right of the
compose area to the top right corner inside the compose textarea /
preview.

The textarea / preview and the button area shares the same grid parent.
25px extra padding is added to and margin is subtracted from the right
of the element so the button is visually inside it. It appears only on
hovering the compose area, and uses a new custom icon.

Fixes: #28791.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compose (misc) in progress redesign Part of the webapp redesign project, including blockers.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants