-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move compose expand/collapse button into text area #28791
Comments
Hello @zulip/design members, this issue was labeled with the "redesign" label, so you may want to check it out! |
Hello @notlelouch! Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
@zulipbot claim |
Hello @ASHUVINAYAK1! Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
hey @alya , if the issue is not resolved ,i can work on this |
hello , if the issue is not resolved yet ,i can work on this |
@zulipbot claim |
Hello @N-Shar-ma! Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose box (textarea). To make space 20px extra padding is added to the right of the compose box. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose box (textarea). To make space 20px extra padding is added to the right of the compose box. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose box (textarea). To make space 20px extra padding is added to the right of the compose box. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: #28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: #28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: #28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: #28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the textarea / preview, and uses a new custom icon. Fixes: #28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: zulip#28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: #28791.
The compose expand / collapse button is moved from the top right of the compose area to the top right corner inside the compose textarea / preview. The textarea / preview and the button area shares the same grid parent. 25px extra padding is added to and margin is subtracted from the right of the element so the button is visually inside it. It appears only on hovering the compose area, and uses a new custom icon. Fixes: #28791.
As part of the compose box redesign, we should move the compose expand/collapse button into the text area.
This issue is part of #24878.
Live demo with the source code on Repl.it. Here is the decomposed source code archive:
compose-decomposed.zip
The css code is split to decomposed areas but all the js code is in a single file. The file isn't big so it is easier to follow the logic of interactions between html and js.
The text was updated successfully, but these errors were encountered: