Improve the find my team page. #3128
Comments
|
@rishig I'd like to take up this issue |
|
Great, thanks! |
|
@amalad Hi! Any progress? I would like to contribute to this issue. :) |
|
Hi @amalad, Are you working on this or should i work on it? |
|
Hi @avisrivastava254084 and @jajodiaraghav , I should be done with it soon. Sorry about the delay. But you can contribute if you feel like it :-) |
|
If you are about to finish it, could you tell me what area can I work on,
in the remaining whatsoever? Thanks :) @amalad
…On Tue, Jan 10, 2017 at 7:54 AM, Amala Deshmukh ***@***.***> wrote:
Hi @avisrivastava254084 <https://github.com/avisrivastava254084> and
@jajodiaraghav <https://github.com/jajodiaraghav> , I should be done with
it soon. Sorry about the delay. But you can contribute if you feel like it
:-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3128 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AM3uL5d_nCyjEsB1o8W6PILdbkUC96i7ks5rQuvwgaJpZM4LcQfd>
.
--
Aviral Srivastava
+918004860407
|
|
@amalad it looks like you don't have enough time to progress on this quickly; can you post your progress as a WIP pull request that @avisrivastava254084 can help pick up? |
|
@avisrivastava254084 @timabbott , sorry about the delay. I'm creating a pull request now |
|
First two pieces were merged via #3565. |
|
Hello @zulip/server-misc members, this issue was labeled with the area: portico label, so you may want to check it out! |
|
I just ran into this page when trying to log into a new Zulip instance, and I was confused -- I initially thought that the point was that I should put in the email addresses of the other people in my groups. Some clearer phrasing, explaining that the user should put in her own email address to get a reminder of what orgs she's in, would be great! |
|
I think @brockwhittaker is making progress on making this page a lot nicer. |
|
"You shouldn't be able to click "Find team" if you don't have a valid list of email addresses." Is this Issue still open. I am new to Zulip. Can I try? |
|
@MohammedKhandwawala go for it! |
|
The thing now works as expected. it doesn't enable submit until all id are valid in the field. How should deactivated submit button should look like?. |
|
Good question. I'm not sure we actually have a deactivated button type for the logged out pages. In that case maybe just add an appropriate CSS class, and we can add to our list for our designer. |
|
@timabbott submitted for review |
Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128
|
@jojongx We noticed that you have not made any updates to this issue or linked PRs for 10 days. Please comment here if you are still actively working on it. Otherwise, we'd appreciate a quick If we don't hear back, you will be automatically unassigned in 4 days. Thanks! |
|
Currently working on it. |
|
@jojongx You can add a draft PR to show the work in progress |
|
@swayam0322 I am gonna make some commits soon. This is my first contribution in OSS so I am not used to the process but I can tell by your commits you know html much better than myself. I may be making some redundant progress however I am just trying to gain OSS experience for University related work.
|
Addressing task 2 of issue zulip#3128 Created logic to send a different email to users requesting to "find accounts" associated with a given non-affiliated email. Past versions simply send nothing if no organizations are found.
Addressing task 2 of issue zulip#3128 Forgot to edit find_team.txt with similar format as find_team.html in previous commit. Note: added basic documentation above decision trees for this commit and prior commit.
|
@swayam0322 I think I fixed task 2 to the best of my ability. I skimmed through your commits and I believe you tackled both of the remaining tasks. I will be "unassigning" shortly if you want to claim the issue and finish anything left (although you seem to have it complete if not very close). Thank you for the opportunity :) |
Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128
Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128
Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128 git add .
Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128
Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128
Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128
Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128
git add . Previously, the emails which weren't connected to a Zulip account were ignored but now they recieve an email stating their email isn't connected to a Zulip account Fixes part of zulip#3128
Previously, email addresses that weren't connected to a Zulip account were ignored but now they receive an email stating their email isn't connected to a Zulip account. Fixes part of zulip#3128 Co-authored-by: Lauryn Menard <lauryn@zulip.com>
Earlier, after a successful POST request on find accounts page users were redirected to a URL with the emails (submitted via form) as URL parameters. Those raw emails in the URL were used to display on a template. We no longer redirect to such a URL; instead, we directly render a template with emails passed as a context variable. Fixes part of zulip#3128
The result page didn't have any resend button a button was added to redirect to the form where the user can find their account Fixes part of zulip#3128
Previously, email addresses that weren't connected to a Zulip account were ignored but now they receive an email stating their email isn't connected to a Zulip account. Fixes part of zulip#3128 Co-authored-by: Lauryn Menard <lauryn@zulip.com>
Previously, email addresses that weren't connected to a Zulip account were ignored but now they receive an email stating their email isn't connected to a Zulip account. Also, removes the "Thanks for using Zulip!" line at the end of the find accounts email that's sent when a Zulip account is found. Fixes part of zulip#3128 Co-authored-by: Lauryn Menard <lauryn@zulip.com>
Previously, email addresses that weren't connected to a Zulip account were ignored but now they receive an email stating their email isn't connected to a Zulip account. Also, removes the "Thanks for using Zulip!" line at the end of the find accounts email that's sent when a Zulip account is found. Updates the i18n test that used this string with another in the German translation from this a successful account found email. Fixes part of zulip#3128 Co-authored-by: Lauryn Menard <lauryn@zulip.com>
Previously, email addresses that weren't connected to a Zulip account were ignored but now they receive an email stating their email isn't connected to a Zulip account. Also, removes the "Thanks for using Zulip!" line at the end of the find accounts email that's sent when a Zulip account is found. Updates the i18n test that used this string with another in the German translation from this a successful account found email. Fixes part of zulip#3128 Co-authored-by: Lauryn Menard <lauryn@zulip.com>
Previously, email addresses that weren't connected to a Zulip account were ignored but now they receive an email stating their email isn't connected to a Zulip account. Also, removes the "Thanks for using Zulip!" line at the end of the find accounts email that's sent when a Zulip account is found. Updates the i18n test that used this string with another in the German translation from this a successful account found email. Fixes part of zulip#3128 Co-authored-by: Lauryn Menard <lauryn@zulip.com>
Previously, email addresses that weren't connected to a Zulip account were ignored but now they receive an email stating their email isn't connected to a Zulip account. Also, removes the "Thanks for using Zulip!" line at the end of the find accounts email that's sent when a Zulip account is found. Updates the i18n test that used this string with another in the German translation from this a successful account found email. Fixes part of zulip#3128 Co-authored-by: Lauryn Menard <lauryn@zulip.com>
Previously, email addresses that weren't connected to a Zulip account were ignored but now they receive an email stating their email isn't connected to a Zulip account. Also, removes the "Thanks for using Zulip!" line at the end of the find accounts email that's sent when a Zulip account is found. Updates the i18n test that used this string with another in the German translation from this a successful account found email. Fixes part of #3128 Co-authored-by: Lauryn Menard <lauryn@zulip.com>
|
Closing as done; let's not worry about the remaining point. |
and others
The find my team page allows users to enter an email address (actually, up to 10 email addresses) and receive an email with a link to the login page of their organization. The basic functionality is there, but it could use a few improvements:
You shouldn't be able to click "Find team" if you don't have a valid list of email addresses. Slack does this really nicely: https://slack.com/signin/find
We should send an email regardless of whether they are in a Zulip org or not.
The followup page should have links to resend the email or enter a different email address.
The URL of the followup page currently has the email as a URL parameter, which should be removed.
Add the
'In the Zulip development environment, outgoing emails are printed to the run-dev.py console.'text (git grepfor it to see how we do it elsewhere)On load, the cursor should go into the box where you enter your email address.
The find my team page is at
http://<host>:9991/find-my-team/. In the dev environment, you'll need to first change'FIND_TEAM_LINK_DISABLED'toFalseinzproject/settings.py.Edit by @alya (2024-01):
E-mail to send when no accounts are found:
Subject: No Zulip accounts found
You have requested a list of Zulip accounts for this email address.
[if on Zulip Cloud]: Unfortunately, no Zulip accounts in Zulip Cloud organizations were found.
[if self-hosted]: Unfortunately, no Zulip accounts were found on this server ({{ server_url }}).
You can check accounts for another email, or [try another way]({{ realm.uri }}/help/logging-in#find-the-zulip-log-in-url) to find your account.
If you do not recognize this request, you can safely ignore this email.
We should also remove this line from the confirmation page: "You will only receive emails at addresses associated with Zulip organizations."
The text was updated successfully, but these errors were encountered: