message edit: Nicer animation on close. #4240
Comments
|
Hello @zulip/server-message-view members, this issue was labeled with the area: message-editing label, so you may want to check it out! |
|
@zulipbot claim |
|
Congratulations, @cakleimeier, you've successfully claimed your first issue! Contributing to Zulip will (hopefully) be a fun and rewarding experience, and I'm here to help get you off to a good start. First things first:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@zulipbot claim |
|
Welcome to Zulip, @swetax! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
Hello @YashRE42, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
|
@zulipbot abandon |
|
@zulipbot claim |
|
Welcome to Zulip, @YashRE42! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
ERROR: You have not claimed this issue to work on yet. |
|
@zulipbot abandon |
|
@zulipbot claim |
|
ERROR: This active issue has no assignee. |
1 similar comment
|
ERROR: This active issue has no assignee. |
|
@zulipbot claim |
|
Welcome to Zulip, @rgogia! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
The hide edit message function runs a jarring animation when a message is edited. This fix alters the animation so that the message appears and the edit box slowly fades away rather than quickly dissapearing Fixes zulip#4240
The hide edit message function runs a jarring animation when a message is edited. This fix alters the animation so that the message appears and the edit box slowly fades away rather than quickly dissapearing Fixes zulip#4240
|
Hello @rgogia, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
This update adds a small animation when the user clicks the pencil icon to get the edit box to appear. The edit box now slides down rather than just appearing. Fixes zulip#4240
The hide edit message function runs a jarring animation when a message is edited. This fix alters the animation so that the message appears and the edit box slowly fades away rather than quickly dissapearing Fixes zulip#4240
This update adds a small animation when the user clicks the pencil icon to get the edit box to appear. The edit box now slides down rather than just appearing. Fixes zulip#4240
|
@zulipbot Still working on this. |
The hide edit message function runs a jarring animation when a message is edited. This fix alters the animation so that the message appears and the edit box slowly fades away rather than quickly dissapearing Fixes zulip#4240
This update adds a small animation when the user clicks the pencil icon to get the edit box to appear. The edit box now slides down rather than just appearing. Fixes zulip#4240
|
@zulipbot claim |
|
Welcome to Zulip, @pateldhwani01! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@zulipbot claim |
|
Hey, I have added a new pull request with a single commit, the PR also consists of a gif showing the changes. If someone could review it, that would be great!! |
|
Closing this, since https://chat.zulip.org/#narrow/stream/6-frontend/topic/.234240.3A.20Message.20edit.20closing.20animations/near/1271233 suggests maybe we don't need an animation here. |
Currently closing the "message edit" or "view source" view is a bit jarring. See for comparison how nice the animation is when we send a new message.
It would be great to add an animation that closed the message edit/view source box more slowly.
The text was updated successfully, but these errors were encountered: