Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right sidebar: Include non-displayed users in typeahead. #5775

Closed
rishig opened this issue Jul 11, 2017 · 8 comments
Closed

right sidebar: Include non-displayed users in typeahead. #5775

rishig opened this issue Jul 11, 2017 · 8 comments

Comments

@rishig
Copy link
Member

rishig commented Jul 11, 2017

If someone is gone for three weeks, we remove them from the right sidebar. We should still include them at the bottom of the user search typeahead, though, since it feels like something is broken when you know someone is part of a realm and you can't find them in user search.

Note that we include all such users in the compose box typeahead, so the list is already being sent to the frontend.

@zulipbot
Copy link
Member

zulipbot commented Jul 11, 2017

Hello @zulip/server-sidebars, @zulip/server-search members, this issue was labeled with the area: right-sidebar, area: search labels, so you may want to check it out!

@anirudhjain75
Copy link
Contributor

@rishig Any idea how do I duplicate the issue, Waiting for three weeks for user to disappear isnt a wise thing to do 😄

@timabbott
Copy link
Sponsor Member

You should be able to replicate locally by temporarily modifying the exclude_old_users function to instead exclude some specific user by ID or email or something.

@wangjames
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Sep 7, 2017

Hello @wangjames, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 7 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

@wangjames
Copy link
Collaborator

Waiting for the refactoring of the right_sidebar using the list_render API as listed in #6133

@zulipbot
Copy link
Member

Hello @wangjames, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 7 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

@wangjames
Copy link
Collaborator

Waiting for the issue as mentioned above

brockwhittaker pushed a commit to brockwhittaker/zulip that referenced this issue Oct 3, 2017
This will look through all users and not just ones active in the last
three weeks but only when you are searching with the right sidebar
input box.

Fixes: zulip#5775.
brockwhittaker pushed a commit to brockwhittaker/zulip that referenced this issue Oct 4, 2017
This will look through all users and not just ones active in the last
three weeks but only when you are searching with the right sidebar
input box.

Fixes: zulip#5775.
brockwhittaker pushed a commit to brockwhittaker/zulip that referenced this issue Oct 4, 2017
This will look through all users and not just ones active in the last
three weeks but only when you are searching with the right sidebar
input box.

Fixes: zulip#5775.
brockwhittaker pushed a commit to brockwhittaker/zulip that referenced this issue Oct 4, 2017
This will look through all users and not just ones active in the last
three weeks but only when you are searching with the right sidebar
input box.

Fixes: zulip#5775.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants