Eliminate rogue logging.basicConfig calls

[gnprice]

The logging.basicConfig function attempts to configure logging globally for the whole program. This can be suitable for a standalone script, but not for part of a large application like our Django app codebase -- if they do anything at all, then they stomp all over the config we've carefully set up in zproject/settings.py.

We have five examples of this outside of scripts, all in zerver/:

zerver/lib/logging_util.py:    logging.basicConfig(format=log_format)
zerver/lib/notifications.py:    logging.basicConfig(filename=settings.DIGEST_LOG_PATH, level=logging.INFO)
zerver/management/commands/email_mirror.py:logging.basicConfig(format=log_format)
zerver/management/commands/process_queue.py:        logging.basicConfig()
zerver/management/commands/runtornado.py:            logging.basicConfig(level=logging.INFO,

Quite possibly they should all just be deleted. This task basically comes down to checking each one and seeing (a) if it's doing anything, and (b) if so, if we want any of what it's doing, and taking care of that some other way.

[zulipbot]

Hello @zulip/server-production members, this issue was labeled with the area: production label, so you may want to check it out!

[timabbott]

I think it'd be a good idea to attempt to address this before the 1.7 release, so that we only need to carefully recheck that the right stuff is in the right log files after your other logging PR once...

[timabbott]

We've only got a couple left outside scripts/ and tools/:

$ git grep logging.basicConfig zerver/
zerver/lib/notifications.py:    logging.basicConfig(filename=settings.DIGEST_LOG_PATH, level=logging.INFO)
zerver/management/commands/email_mirror.py:logging.basicConfig(format=log_format)
zerver/management/commands/process_queue.py:        logging.basicConfig()
zerver/management/commands/runtornado.py:            logging.basicConfig(level=logging.INFO,

Might be worth putting finishing this and then lint-banning it in zerver/ soon.

[zulipbot]

Hello @gnprice, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!