Oauth/Social backends - very minor cleanup #13195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOCIAL_AUTH_BACKEND / OAUTH_BACKEND_NAMES are currently the same backends. All Oauth backends are social, and all social are oauth. So we get rid of OAUTH_BACKEND_NAMES and use only SOCIAL_AUTH_BACKENDS.
any_oauth_backend_enabled is all about whether we will have extra buttons on the login/register pages for logging in with some non-native backends (like Github, Google etc.). And this isn't about specifically oauth backends, but generally "social" backends - that may not rely specifically rely on Oauth. This will have more concrete relevance when SAML authentication is added - which will be a "social" backend, requiring an additional button, but not Oauth-based.
|
These are great, merged, thanks @mateuszmandera! Effectively cleanups we should have done after we integrated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the commits, there is a bit of a weird juggling of "social backend" / "oauth backend" concepts in the code, where we're better served just thinking of "social backends".
Otherwise, when we add SAML, we would have to add some additional logic dealing with the fact that it's a "social" backend, but not an oauth backend and things would just get more confusing, for no benefit.