Fix TypeError in Google OAuth authenticator #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof, this changed in Two quick things:
|
yuvipanda
changed the title
|
I've signed the CLA, I'll redo the commit message later :) |
yuvipanda
changed the title
requests 1.0 changed response.json attribute to response.json() instancemethod. The code wasn't updated to match that change, causing a TypeError when attempting to use the Google OAuth Authenticator backend. This is fixed simply by using response.json() instead of response.json.
|
{{done}} |
|
Merged, thanks for tracking this down! |
swayam0322
added a commit
to swayam0322/zulip
that referenced
this pull request
Jan 12, 2024
# This is the 1st commit message: portico: remove URL parameter changes more changes # This is the commit message zulip#2: support: Update validation for adding or updating a discount. Updates the HTML input field to have a min of 0, max of 99.99 and allow increments of 0.01. Also, use format_discount_percentage for displaying the customer default discount in the support form. # This is the commit message zulip#3: api_docs: Update doc for realm_push_notification_enabled_end_timestamp. This commit updates the doc to explicitly mention that 'realm_push_notifications_enabled_end_timestamp' is a UNIX timestamp. # This is the commit message zulip#4: stripe: Fix the invoice item description for flat discounts. Earlier, in process_initial_upgrade, the flat_discount value wasn't converted into dollars when specified in the invoice description, resulting in showing the incorrect value of $2000 as a discount. This commit converts the value in cents to dollars and adds tests to verify the invoice generated. # This is the commit message zulip#5: docs: Fix selfhoster URL to be the canonical one. We redirect from `/serverlogin` to `/serverlogin/`, so save a 301. # This is the commit message zulip#6: stream_topic_history_util: Convert module to typescript. # This is the commit message zulip#7: message_edit: Consolidate styles into message row CSS. # This is the commit message zulip#8: message_edit: Remove styles with no associated structure. # This is the commit message zulip#9: message_edit: Lay out edit buttons with flexbox. # This is the commit message zulip#10: message_row: Remove styles and JS for nonexistant .sender-status. # This is the commit message zulip#11: message_row: Remove unnecessary .sender-status-controls style and structure. # This is the commit message zulip#12: settings: Fix setting label click functionality. This commit fixes "Automatically follow topics where I'm mentioned" setting label click functionality so that the setting is toggled on clicking the label. # This is the commit message zulip#13: web: Fix links which were missing trailing slashes. # This is the commit message zulip#14: docs: Fix help links for pm -> dm rename, to save a redirect. # This is the commit message zulip#15: docs: Fix other help pages that were renamed or moved, to save a redirect. # This is the commit message zulip#16: user_status: Fix parsing of partial user_status events. Signed-off-by: Anders Kaseorg <anders@zulip.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests 1.0 changed response.json attribute to response.json() instancemethod.
The code wasn't updated to match that change, causing a TypeError when attempting
to use the Google OAuth Authenticator backend.
This is fixed simply by using response.json() instead of response.json