Poll time widget #17360
Poll time widget #17360
Conversation
|
Hello @zulip/server-message-view members, this pull request was labeled with the "area: message view" label, so you may want to check it out! |
godlike786
force-pushed
the
poll-time-widget
branch
4 times, most recently
from
8ea4929
to
9933ca4
Compare
godlike786
force-pushed
the
poll-time-widget
branch
from
ef168ed
to
fa2e540
Compare
|
@zulipbot add "needs review" |
godlike786
force-pushed
the
poll-time-widget
branch
2 times, most recently
from
acb4259
to
c561703
Compare
|
@andersk I have fixed the issues pointed by you in the subsequent commits. Could you review this PR again and merge it? |
|
@godlike786 thanks for working on this! Please squash the fixes into the original commit that introduced the relevant bugs -- the goal is to make a readable branch consisting of atomically correct commits. Check out the Zulip commit guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html |
godlike786
force-pushed
the
poll-time-widget
branch
from
c561703
to
fb26470
Compare
Move the right sidebar which is a bit to the left, to the right side of the page. The entire column is moved to the right. The change is brought about by removing "right" CSS property on 'column-right' class Fixes zulip#17307
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821 poll time widget: Add time widget markdown parser to polls Time widget markdown parser functionality added to poll question header. The change is brought about by applying `update_elements` function on the poll question header.And in `rendered_markdown.js` a parsing function is added to render the timestamp Fixes zulip#16821 [Poll Time Widget] Add time widget markdown parser to poll question The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. Fixes zulip#16821 [Poll Time Widget] Add time widget markdown parser to poll question The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821 Remove unused-vars Fixes zulip#16821 Fixed linting issue in `poll_widget.js` Fixes zulip#16821
godlike786
force-pushed
the
poll-time-widget
branch
from
fb26470
to
b35c238
Compare
|
@timabbott I have squashed the commits as you mentioned. |
|
Thanks for working on this @godlike786! Unfortunately, I think it really only makes sense to do a more generic feature for allowing the markdown processor to run on poll entries than something that allows doing so only if there's Unfortunately, the architecture of our widgets doesn't make that super convenient to do without security model impact (switching to the frontend markdown processor for rendering user-facing content for other users, not just for yourself), which you needed to do to make this PR work anyway. I'm not sure if that means we should abandon this or try to do a design for markdown-in-poll widgets more broadly. |
|
@timabbott I could come up with writing a more generic markdown processor for the poll widgets. |
|
Heads up @godlike786, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
timabbott
force-pushed
the
main
branch
2 times, most recently
from
4ec3636
to
88b200c
Compare
|
Closing in favor of #28079. |
Fixes #16821
Testing plan:
GIFs or screenshots:
