subs: Update sub object with additional properties in update_* functions.
#18910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zulip/server-settings members, this pull request was labeled with the "area: settings UI" label, so you may want to check it out! |
ganpa3
changed the title
sub object with additional properties in update_* functions.sub object with additional properties in update_* functions.
ganpa3
force-pushed
the
update_subs_objects
branch
2 times, most recently
from
0a0fc8e
to
51c7078
Compare
ganpa3
changed the title
sub object with additional properties in update_* functions.sub object with additional properties in update_* functions.
ganpa3
force-pushed
the
update_subs_objects
branch
from
51c7078
to
f06e399
Compare
…acy_policy. The passed `stream_privacy_policy_values` object doesn't contain the `everyone` property.
…tions. Subsequent function calls require additional properties present after calling `get_sub_for_settings` on the original sub object. Fixes zulip#18602
ganpa3
force-pushed
the
update_subs_objects
branch
from
f06e399
to
2ed4e13
Compare
|
Merged, thanks @ganpa3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All.messages.-.Zulip.Dev.-.Zulip.-.Google.Chrome.2021-06-18.20-10-46.mp4