compose: Fix compose-preview size in expanded mode. #19321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS properties used to make the
#compose-textarea
full-sizewere missing for the
#preview_message_area
, thus, it was justgetting to the height as specified in the
max-height
propertyof
#preview_compose_box
.Adding the missing CSS properties resolved the problem, but only
for not-too-long messages. For very-long messages, the preview
message area was overflowing the parent container (attaining the
maximum height possible according to the content, due to the absence
of max-height), which led to the controls below compose-box to
disappear.
Adding an additional property of
height: 1.5em
solved this problem,as if a height lower than min-height is set to an element, it attains
its min-height.
Tested manually on my Ubuntu Development environment.
Fixes: #19243.
GIFs or screenshots:
Without height property
![Screenshot from 2021-07-20 01-01-27](https://user-images.githubusercontent.com/39924567/126216582-3eb6f196-b647-4b95-9109-82c399758467.png)
With height property
![Screenshot from 2021-07-20 01-02-32](https://user-images.githubusercontent.com/39924567/126217255-16255bf0-6747-475b-a83b-a763cc4f2ea9.png)