compose: Fix compose-preview size in expanded mode. #19321
Conversation
The CSS properties used to make the `#compose-textarea` full-size were missing for the `#preview_message_area`, thus, it was just getting to the height as specified in the `max-height` property of `#preview_compose_box`. Adding the missing CSS properties resolved the problem, but only for not-too-long messages. For very-long messages, the preview message area was overflowing the parent container (attaining the maximum height possible according to the content, due to the absence of max-height), which led to the controls below compose-box to disappear. Adding an additional property of `height: 1.5em` solved this problem, as if a height lower than min-height is set to an element, it attains its min-height. Tested manually on my Ubuntu Development environment. Fixes: zulip#19243.
|
Hello @zulip/server-compose members, this pull request was labeled with the "area: compose" label, so you may want to check it out! |
|
I tried a lot to find a way to do this without adding an extra height property but couldn't find any. @Signior-X can you please take a look at this and suggest if you have any better way of preventing |
|
This looks reasonable to me, but I'll hold off on merging until @Signior-X can take a look at it, in case he has better ideas or additional context that can help. |
So, I also tried it. But I think that the simplebar is handling the scroll here and I tried seeing any other way. I feel this solution is the best one. Also, I tried just removing With |
|
Merged, thanks folks! |
The CSS properties used to make the
#compose-textareafull-sizewere missing for the
#preview_message_area, thus, it was justgetting to the height as specified in the
max-heightpropertyof
#preview_compose_box.Adding the missing CSS properties resolved the problem, but only
for not-too-long messages. For very-long messages, the preview
message area was overflowing the parent container (attaining the
maximum height possible according to the content, due to the absence
of max-height), which led to the controls below compose-box to
disappear.
Adding an additional property of
height: 1.5emsolved this problem,as if a height lower than min-height is set to an element, it attains
its min-height.
Tested manually on my Ubuntu Development environment.
Fixes: #19243.
GIFs or screenshots:
Without height property
With height property
